Skip to content

Add integration tests that detect race condition to test-infra#1215

Merged
istio-testing merged 3 commits intoistio:masterfrom
lei-tang:add-race-detection-integration-tests
Apr 18, 2019
Merged

Add integration tests that detect race condition to test-infra#1215
istio-testing merged 3 commits intoistio:masterfrom
lei-tang:add-race-detection-integration-tests

Conversation

@lei-tang
Copy link
Copy Markdown
Contributor

@lei-tang lei-tang commented Apr 15, 2019 •
edited
Loading

This PR is for #13341 and depends on the PR istio/istio#13342, which has been merged.

@googlebot googlebot added the cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. label Apr 15, 2019
@lei-tang lei-tang changed the title Add integration tests that detect race condition Add integration tests that detect race condition to test-infra Apr 15, 2019
@utka
Copy link
Copy Markdown
Contributor

utka commented Apr 15, 2019

Don't you mind adding it as postsubmit first to check that it is not flaky?

@lei-tang
Copy link
Copy Markdown
Contributor Author

lei-tang commented Apr 15, 2019

Done: added it as postsubmit first.

@lei-tang lei-tang mentioned this pull request Apr 15, 2019
Merged
@utka
Copy link
Copy Markdown
Contributor

utka commented Apr 18, 2019

/lgtm
/approve

@istio-testing
Copy link
Copy Markdown
Collaborator

istio-testing commented Apr 18, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lei-tang, utka

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@istio-testing istio-testing merged commit 3be356b into istio:master Apr 18, 2019
@istio-testing
Copy link
Copy Markdown
Collaborator

istio-testing commented Apr 18, 2019

@lei-tang: Updated the job-config configmap using the following files:

  • key istio.istio.master.yaml using file prow/cluster/jobs/istio/istio/istio.istio.master.yaml
Details

In response to this:

This PR is for #13341 and depends on the PR istio/istio#13342, which has been merged.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@lei-tang
Copy link
Copy Markdown
Contributor Author

lei-tang commented Apr 18, 2019

istio/istio#13341

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sebastienvas sebastienvas Awaiting requested review from sebastienvas

@utka utka Awaiting requested review from utka

Assignees

@utka utka

Labels

cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@lei-tang @utka @istio-testing @googlebot