Skip to content

add sds e2e test to test-infra#1143

Merged
istio-testing merged 2 commits intoistio:masterfrom
quanjielin:quanlinpretest0111
Jan 11, 2019
Merged

add sds e2e test to test-infra#1143
istio-testing merged 2 commits intoistio:masterfrom
quanjielin:quanlinpretest0111

Conversation

@quanjielin
Copy link
Copy Markdown
Contributor

@quanjielin quanjielin commented Jan 11, 2019

@googlebot googlebot added the cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. label Jan 11, 2019
@quanjielin
Copy link
Copy Markdown
Contributor Author

quanjielin commented Jan 11, 2019

/assign @hklai

@quanjielin
Copy link
Copy Markdown
Contributor Author

quanjielin commented Jan 11, 2019

@hklai, after submit, the new test will be shown in istio/istio presubmit test immediately or is there any other change/deploy need to be made ?

@sebastienvas
Copy link
Copy Markdown
Contributor

sebastienvas commented Jan 11, 2019

They should be added automatically after sometime.

hklai
hklai reviewed Jan 11, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@hklai hklai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you want to add it to postsubmit as well?

@quanjielin
Copy link
Copy Markdown
Contributor Author

quanjielin commented Jan 11, 2019

added to postsubmit, PTAL, thanks !

hklai
hklai approved these changes Jan 11, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@hklai hklai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@istio-testing
Copy link
Copy Markdown
Collaborator

istio-testing commented Jan 11, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hklai, quanjielin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@istio-testing istio-testing merged commit 56f57fb into istio:master Jan 11, 2019
@istio-testing
Copy link
Copy Markdown
Collaborator

istio-testing commented Jan 11, 2019

@quanjielin: Updated the job-config configmap using the following files:

  • key istio.istio.release-1.1.yaml using file prow/cluster/jobs/istio/istio/istio.istio.release-1.1.yaml
Details

In response to this:

istio/istio#9035

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@quanjielin quanjielin deleted the quanlinpretest0111 branch January 11, 2019 23:36
This was referenced Jan 19, 2019
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sebastienvas sebastienvas Awaiting requested review from sebastienvas

1 more reviewer

@hklai hklai hklai approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@hklai hklai

Labels

cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@quanjielin @sebastienvas @istio-testing @hklai @googlebot