enable DLB connection balance extension#4320
Conversation
|
😊 Welcome @daixiang0! This is either your first contribution to the Istio proxy repo, or it's been You can learn more about the Istio working groups, code of conduct, and contributing guidelines Thanks for contributing! Courtesy of your friendly welcome wagon. |
|
wasm test failed /retest |
|
@istio/wg-policies-and-telemetry-maintainers please review. |
|
@kfaseela have same request in istio/istio#42380. I think istio need a clear rule about contrib filter import policy. |
They are different cases: Postgres has been moved from core to contrib, but no move history for DLB. Also, it is not a filter, actually, it accelerates connection balance inside Envoy, which means all key applications like ingress gateway can get benefit from it. It's more like #4202. |
|
/retest |
Signed-off-by: Loong <loong.dai@intel.com>
zirain
left a comment
There was a problem hiding this comment.
seems reasonable, left to @kyessenov for another look.
|
I don't think we can say "no" after accepting cryptomb and other contrib accelerators. |
|
Per-usual: please work with Istio community to define a first-class API (not EnvoyFilter). Without that, users cannot assume this extension works for managed versions of Istio. |
|
@kyessenov Thanks, I will do it:) |
|
IMO, crytoMB is different. We have an API for it already. I certainly think we need a process around bringing Envoy contrib extensions to Istio Proxy. Otherwise it has potential to destabilize Istio proxy. |
|
@ramaraochavali That's quite surprising to have a de-facto stable API (Mesh) to depend on a contrib extension in Envoy (which is technically "experimental"). What matters is that they should be aligned: an experimental Istio API can depend on contrib Envoy extension, but a stable Istio API should not depend on contrib. @ramaraochavali Does Istio have a way to define experimental APIs? I think almost all versions have been pretty much stuck under v1alpha1. |
I agree. |
|
Since you're a lead, do you mind raising the issue of "how do we define (reversible) experimental API changes" to ToC? If the answer is "use EnvoyFilter" then we need to revert the mesh config change for contrib extensions. For postgres, I'm not even sure EnvoyFilter can handle generation of multiple filter chains for postgres ports. |
|
@kyessenov do you know which release would include this feature? |
Signed-off-by: Loong loong.dai@intel.com
What this PR does / why we need it:
It is to enable DLB connection balance extension.
DLB support in Envoy is merged and available from envoyproxy/envoy#20268
Intel® Dynamic Load Balancer (Intel® DLB) is a hardware managed system of queues and arbiters connecting producers and consumers. It is a PCI device envisaged to live in the server CPU uncore and can interact with software running on cores, and potentially with other devices. More details please refer to https://www.intel.com/content/www/us/en/download/686372/intel-dynamic-load-balancer.html.
Special notes for your reviewer:
With EnvoyFilter, this feature can work, no more extra integration work in Istio side.