CC @envoyproxy/api-shepherds: Your approval is needed for changes made to (api/envoy/|docs/root/api-docs/).
envoyproxy/api-shepherds assignee is @lizan
CC @envoyproxy/api-watchers: FYI only for changes made to (api/envoy/|docs/root/api-docs/).

/retest

Retrying Azure Pipelines:
Retried failed jobs in: envoy-presubmit

maybe add some comments on what the extend_loadbalance is.

It is hard to say as it depends on implement :(

@lizan what else should I do?

Sorry for the force push due to the wrong sign-off.

@mattklein123 hi, I want to ask a question:
Now we use ActiveTcpListener to post socket to balance, which is totally software level. Now I want to extend it offload, my basic thought is that send the connection to the hardware by pickTargetHandler, then register a callback to listen to events from the hardware and continue to handle connections by registerHandler. But in this way, I can not call ActiveTcpListener::onAcceptWorker since ExtendBalancer is a parent but ActiveTcpListener is a child, direct call breaks inheritance relationship(I do not like it). Can I call onSocketAccepted directly?

The old abstract flow:
connection accepted -> pick the most free thread -> if itself -> handle connection
| -> if not -> send connection to it -> handle connection
The new abstract flow:
connection accepted -> send the connection to the hardware
a thread selected by the hardware get the connection by event -> handle connection

Sorry it's hard for me to follow what you are trying to achieve and/or the questions you have. At a high level, post is asynchronous. As such, you should be able to post once you figure out where you want to send the event. If you want to do a small design document that might help to have a bigger picture of what you are trying to achieve.

@mattklein123 thanks for your input, I will create a doc with code flow, it may help you understand.

/wait-any

@mattklein123 @lizan sorry for the slow process of design, here is the link, please let me know if anything wrong.

Also I find that connection balance does not have its own factory, but socket(SocketInterfaceBase) does. For extension purposes, need I also implement something like SocketInterfaceBase to make it easier to extend?

In the design, I create one factory only for one case.

Please make the design doc world readable. Thank you.

@mattklein123 Oops, I have updated the link, it is a very initial version to iterate on, please try again, thanks a lot!

/wait for design review

/assign-from @envoyproxy/api-shepherds @envoyproxy/dependency-shepherds

@envoyproxy/api-shepherds assignee is @mattklein123
@envoyproxy/dependency-shepherds assignee is @mattklein123

@mattklein123 friendly ping :)

/retest

Retrying Azure Pipelines:
Retried failed jobs in: envoy-presubmit

@phlax can you approve/merge when you are satisfied?

@mattklein123 @phlax thanks for your review and help!