Extract service name from request host and cluster name#2548
Merged
istio-testing merged 15 commits intoistio:masterfrom Dec 14, 2019
Merged
Extract service name from request host and cluster name#2548istio-testing merged 15 commits intoistio:masterfrom
istio-testing merged 15 commits intoistio:masterfrom
Conversation
rshriram
reviewed
Nov 11, 2019
lambdai
reviewed
Nov 12, 2019
lambdai
reviewed
Nov 12, 2019
lambdai
reviewed
Nov 12, 2019
Contributor
lambdai
left a comment
There was a problem hiding this comment.
Much more elegant than before!
Leave a mixer expert to final approve
Contributor
|
It appears upstream SSL info is not filled in onLog. I'll need to look further into this. |
Contributor
|
The failure seems to be caused by an uninitialized field service_auth_policy in request info struct. |
kyessenov
reviewed
Dec 11, 2019
Contributor
Author
|
Can I get some review on this PR? It would be nice to get this into 1.4 as well, so that we could gain more parity with mixer. |
kyessenov
approved these changes
Dec 13, 2019
Contributor
kyessenov
left a comment
There was a problem hiding this comment.
Looks good. A couple of small code nits.
Collaborator
|
In response to a cherrypick label: #2548 failed to apply on top of branch "release-1.4": |
bianpengyuan
added a commit
to bianpengyuan/proxy
that referenced
this pull request
Dec 30, 2019
* support extracing service name from request host * service_name:port * s/namespace_pos/name_pos * update * lint * add initialization to service auth policy * format * use absl time * update test * address comment
bianpengyuan
added a commit
to bianpengyuan/proxy
that referenced
this pull request
Dec 31, 2019
* support extracing service name from request host * service_name:port * s/namespace_pos/name_pos * update * lint * add initialization to service auth policy * format * use absl time * update test * address comment
istio-testing
pushed a commit
that referenced
this pull request
Jan 3, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To avoid introducing throw away code to get node information from root context, this change also moves request_info out stream context, which removes computation of request duration and size and use property abi to fetch them from host directly. These changes should be trivial and safe, we could do manual testing to de-risk cherry-pick of this pr to 1.4.