Clarify environment variables set in .profile#919
Clarify environment variables set in .profile#919istio-merge-robot merged 1 commit intoistio:masterfrom sdake:918
Conversation
|
Hi @sdake. Thanks for your PR. I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/assign @andraxylia |
Fixes (#918) Prior to this small change, the .profile settings were not completely obvious. Now all profile settings that Istio should expect to use are set in one place.
|
@sdake glad to see you again in istio! |
|
@gyliu513 yo dude, morning, Istio lucky to have you 👍 |
|
/ok-to-test |
|
/test e2e-suite-rbac-no_auth |
|
/release-note-none |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gyliu513, rshriram The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
|
/test all [submit-queue is verifying that this PR is safe to merge] |
|
Automatic merge from submit-queue |
Automatic merge from submit-queue Clarify how GITHUB_USER should be setup in the development guide. Fixes (#918) This is a follow up change to PR #919: Clarify environment variables set in .profile Prior to this small change, the .profile settings were not completely obvious. Now all profile settings that Istio should expect to use are set in one place **Release Note** NONE **Release note**: ```release-note NONE ```
Automatic merge from submit-queue Clarify how GITHUB_USER should be setup in the development guide. Fixes (#918) This is a follow up change to PR #919: Clarify environment variables set in .profile Prior to this small change, the .profile settings were not completely obvious. Now all profile settings that Istio should expect to use are set in one place **Release Note** NONE **Release note**: ```release-note NONE ``` Former-commit-id: 8bb136a
Automatic merge from submit-queue Clarify environment variables set in .profile Fixes (istio#918) Prior to this small change, the .profile settings were not completely obvious. Now all profile settings that Istio should expect to use are set in one place. **Release note**: NONE Former-commit-id: 977a1af
…tio#947) Automatic merge from submit-queue Clarify how GITHUB_USER should be setup in the development guide. Fixes (istio#918) This is a follow up change to PR istio#919: Clarify environment variables set in .profile Prior to this small change, the .profile settings were not completely obvious. Now all profile settings that Istio should expect to use are set in one place **Release Note** NONE **Release note**: ```release-note NONE ``` Former-commit-id: 8bb136a
Automatic merge from submit-queue Clarify how GITHUB_USER should be setup in the development guide. Fixes (#918) This is a follow up change to PR #919: Clarify environment variables set in .profile Prior to this small change, the .profile settings were not completely obvious. Now all profile settings that Istio should expect to use are set in one place **Release Note** NONE **Release note**: ```release-note NONE ``` Former-commit-id: 8bb136a
* Use mixerclient with status code fix * Update config.yml
Signed-off-by: Jacek Ewertowski <jewertow@redhat.com>
Fixes (#918)
Prior to this small change, the .profile settings were not completely
obvious. Now all profile settings that Istio should expect to use
are set in one place.
Release note:
NONE