Skip to content

Add support for healthy panic threshold (#4488)#9176

Merged
rshriram merged 1 commit intoistio:release-1.1from
knrc:istio-4488
Nov 9, 2018
Merged

Add support for healthy panic threshold (#4488)#9176
rshriram merged 1 commit intoistio:release-1.1from
knrc:istio-4488

Conversation

@knrc
Copy link
Copy Markdown

@knrc knrc commented Oct 5, 2018

No description provided.

@istio-testing
Copy link
Copy Markdown
Collaborator

istio-testing commented Oct 5, 2018

Hi @knrc. Thanks for your PR.

I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knrc
Copy link
Copy Markdown
Author

knrc commented Oct 5, 2018

This PR will need to be updated when the api changes are approved, in the meantime I've copied them into the vendor directory so reviewers can see what is proposed

This was referenced Oct 5, 2018
Closed
Closed
Merged
@istio-testing istio-testing added the needs-rebase Indicates a PR needs to be rebased before being merged label Oct 14, 2018
@codecov
Copy link
Copy Markdown

codecov bot commented Oct 22, 2018 •
edited
Loading

Codecov Report

Merging #9176 into release-1.1 will increase coverage by 1%.
The diff coverage is 20%.

Impacted file tree graph

@@              Coverage Diff              @@
##           release-1.1   #9176     +/-   ##
=============================================
+ Coverage           70%     71%     +1%     
=============================================
  Files              434     430      -4     
  Lines            40977   39735   -1242     
=============================================
- Hits             28577   27860    -717     
+ Misses           11027   10539    -488     
+ Partials          1373    1336     -37
Impacted Files Coverage Δ
pilot/pkg/networking/core/v1alpha3/cluster.go 83% <0%> (+7%) ⬆️
pilot/pkg/model/validation.go 83% <100%> (ø) ⬆️
mixer/adapter/solarwinds/metrics_handler.go 70% <0%> (-14%) ⬇️
pilot/pkg/networking/core/v1alpha3/configgen.go 70% <0%> (-12%) ⬇️
pilot/pkg/proxy/envoy/v2/cds.go 54% <0%> (-10%) ⬇️
pilot/pkg/proxy/envoy/v2/lds.go 48% <0%> (-9%) ⬇️
galley/pkg/kube/interfaces.go 50% <0%> (-8%) ⬇️
pilot/pkg/networking/core/v1alpha3/route/route.go 73% <0%> (-8%) ⬇️
mixer/pkg/protobuf/yaml/resolver.go 95% <0%> (-5%) ⬇️
mixer/pkg/config/mcp/backend.go 67% <0%> (-4%) ⬇️
... and 82 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f7b9bd2...f03673f. Read the comment docs.

@istio-testing istio-testing removed the needs-rebase Indicates a PR needs to be rebased before being merged label Oct 22, 2018
@knrc knrc force-pushed the istio-4488 branch 3 times, most recently from 2ed94bc to 709f7c8 Compare October 26, 2018 18:27
@istio-testing istio-testing added the needs-rebase Indicates a PR needs to be rebased before being merged label Oct 26, 2018
@googlebot
Copy link
Copy Markdown
Collaborator

googlebot commented Oct 26, 2018

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

@googlebot googlebot added cla: no Set by the Google CLA bot to indicate the author of a PR has not signed the Google CLA. and removed cla: yes labels Oct 26, 2018
@knrc knrc changed the base branch from master to release-1.1 October 26, 2018 18:38
@googlebot
Copy link
Copy Markdown
Collaborator

googlebot commented Oct 26, 2018

CLAs look good, thanks!

@googlebot googlebot added cla: yes and removed cla: no Set by the Google CLA bot to indicate the author of a PR has not signed the Google CLA. labels Oct 26, 2018
@istio-testing istio-testing removed the needs-rebase Indicates a PR needs to be rebased before being merged label Oct 26, 2018
@rshriram
Copy link
Copy Markdown
Member

rshriram commented Nov 8, 2018

/ok-to-test

@istio-testing istio-testing added ok-to-test Set this label allow normal testing to take place for a PR not submitted by an Istio org member. and removed needs-ok-to-test labels Nov 8, 2018
@knrc
Copy link
Copy Markdown
Author

knrc commented Nov 9, 2018

/retest

@knrc
Copy link
Copy Markdown
Author

knrc commented Nov 9, 2018

/assign @rshriram

@knrc
Copy link
Copy Markdown
Author

knrc commented Nov 9, 2018

/test e2e-simple

@istio-testing
Copy link
Copy Markdown
Collaborator

istio-testing commented Nov 9, 2018

@knrc: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
prow/e2e-mixer-no_auth-mcp.sh f03673f link /test e2e-mixer-no_auth-mcp
prow/istio-integ-local-tests.sh f03673f link /test istio-integ-local-tests
prow/istio-integ-k8s-tests.sh f03673f link /test istio-integ-k8s-tests
prow/istio-unit-tests.sh f03673f link /test istio-unit-tests
Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

rshriram
rshriram approved these changes Nov 9, 2018
View reviewed changes
Copy link
Copy Markdown
Member

@rshriram rshriram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@istio-testing
Copy link
Copy Markdown
Collaborator

istio-testing commented Nov 9, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: knrc, rshriram

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rshriram rshriram merged commit 687ab4d into istio:release-1.1 Nov 9, 2018
@knrc knrc mentioned this pull request Mar 1, 2019
Closed
7 tasks
brian-avery pushed a commit to brian-avery/istio that referenced this pull request Apr 15, 2021
@istio-testing @jacob-delgado
[release-1.9] Update the announcement for the recently disclosed envo…
49986cf 
…y cve (istio#9176)

* Update the announcement for the recently disclosed envoy cve

* add spelling

* Add vector string

Co-authored-by: Jacob Delgado <jacob.delgado@volunteers.acasi.info>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hklai hklai Awaiting requested review from hklai

@qiwzhang qiwzhang Awaiting requested review from qiwzhang

1 more reviewer

@rshriram rshriram rshriram approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@rshriram rshriram

Labels

ok-to-test Set this label allow normal testing to take place for a PR not submitted by an Istio org member.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@knrc @istio-testing @googlebot @rshriram