Use correct image for init-container (s/runtime/init)#86
Merged
ayj merged 2 commits intoistio:masterfrom Mar 23, 2017
ayj:fix-type-in-getting-started
Merged
Use correct image for init-container (s/runtime/init)#86ayj merged 2 commits intoistio:masterfrom ayj:fix-type-in-getting-started
ayj merged 2 commits intoistio:masterfrom
ayj:fix-type-in-getting-started
Conversation
Collaborator
|
Jenkins job istio/presubmit passed |
2 similar comments
Collaborator
|
Jenkins job istio/presubmit passed |
Collaborator
|
Jenkins job istio/presubmit passed |
Member
|
Good catch! Thanks for fixing this. |
rshriram
approved these changes
Mar 23, 2017
Collaborator
|
Jenkins job istio/presubmit passed |
zenlint
pushed a commit
to zenlint/istio
that referenced
this pull request
Aug 30, 2017
* Add auth concept doc * Fix header * Fix header * Address comments, update figures * merge with upstream master * Sync ahead * Address comment * Address comment * Address comment * Address comments * Address comments * Address comments * Fix index format issue * revert * Test
guptasu
pushed a commit
to guptasu/istio
that referenced
this pull request
Jun 11, 2018
kyessenov
pushed a commit
to kyessenov/istio
that referenced
this pull request
Aug 13, 2018
* add more client_impl tests. * add more unit tests for client_impl
rajusharma
pushed a commit
to rajusharma/istio
that referenced
this pull request
Jul 2, 2019
howardjohn
pushed a commit
to howardjohn/istio
that referenced
this pull request
Jan 12, 2020
* Dynamic validation Signed-off-by: Serguei Bezverkhi <sbezverk@cisco.com> * Fix lint failure Signed-off-by: Serguei Bezverkhi <sbezverk@cisco.com> * make validation a separate func to be called by type Validation func Signed-off-by: Serguei Bezverkhi <sbezverk@cisco.com> * Add root of Values and root of IstioControlPlaneSpec to pass to Validation Signed-off-by: Serguei Bezverkhi <sbezverk@cisco.com> * Refactor to use the recursion Signed-off-by: Serguei Bezverkhi <sbezverk@cisco.com> * pushing again Signed-off-by: Serguei Bezverkhi <sbezverk@cisco.com> * Address comments Signed-off-by: Serguei Bezverkhi <sbezverk@cisco.com> * Addressing comment Signed-off-by: Serguei Bezverkhi <sbezverk@cisco.com> * Moving validation out of v1alpha2 package Signed-off-by: Serguei Bezverkhi <sbezverk@cisco.com> * Start adding per type validations Signed-off-by: Serguei Bezverkhi <sbezverk@cisco.com> * Address lint messages Signed-off-by: Serguei Bezverkhi <sbezverk@cisco.com> * rebase Signed-off-by: Serguei Bezverkhi <sbezverk@cisco.com> * refactor validate to validate slices Signed-off-by: Serguei Bezverkhi <sbezverk@cisco.com> * Fix lint warning Signed-off-by: Serguei Bezverkhi <sbezverk@cisco.com> * remove rebase leftover Signed-off-by: Serguei Bezverkhi <sbezverk@cisco.com> * Another lint warning Signed-off-by: Serguei Bezverkhi <sbezverk@cisco.com> * Add unit tests Signed-off-by: Serguei Bezverkhi <sbezverk@cisco.com> * Split map and slice processing Signed-off-by: Serguei Bezverkhi <sbezverk@cisco.com> * add License to test file Signed-off-by: Serguei Bezverkhi <sbezverk@cisco.com> * Lint error Signed-off-by: Serguei Bezverkhi <sbezverk@cisco.com> * Addressing comments Signed-off-by: Serguei Bezverkhi <sbezverk@cisco.com> * Addressing comments Signed-off-by: Serguei Bezverkhi <sbezverk@cisco.com> * Addressing lint error Signed-off-by: Serguei Bezverkhi <sbezverk@cisco.com> * Addressing lint error Signed-off-by: Serguei Bezverkhi <sbezverk@cisco.com>
deva26
pushed a commit
to deva26/istio
that referenced
this pull request
Jun 24, 2020
…-metrics Remove non relevant metrics
luksa
pushed a commit
to luksa/istio
that referenced
this pull request
Oct 14, 2024
…er-merge_upstream_istio_master-6253864e Automator: merge upstream changes to openshift-service-mesh/istio@master
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
doc/getting-started.mdinstructions didn't work for me with this fix, but we weren't really going through the proxy anyway because the iptable rules weren't setup.This change is