Skip to content

Merge latest master into collab-gcp-identity#8041

Merged
hklai merged 322 commits intoistio:collab-gcp-identityfrom
quanjielin:quanlinmerge0817
Aug 18, 2018
Merged

Merge latest master into collab-gcp-identity#8041
hklai merged 322 commits intoistio:collab-gcp-identityfrom
quanjielin:quanlinmerge0817

Conversation

@quanjielin
Copy link
Copy Markdown
Contributor

@quanjielin quanjielin commented Aug 17, 2018

Step 2 of #8009

rshriram and others added 30 commits July 19, 2018 23:13
* update envoy sha - fix memory leak

Signed-off-by: Shriram Rajagopalan <shriramr@vmware.com>

* Fixing assorted bugs in service entries using filter chain matches

Signed-off-by: Shriram Rajagopalan <shriramr@vmware.com>

* format

* bug fix

Signed-off-by: Shriram Rajagopalan <shriramr@vmware.com>

* lint

Signed-off-by: Shriram Rajagopalan <shriramr@vmware.com>

* lint

Signed-off-by: Shriram Rajagopalan <shriramr@vmware.com>

* multicluster bug fixes

Signed-off-by: Shriram Rajagopalan <shriramr@vmware.com>

* backward compatibility

Signed-off-by: Shriram Rajagopalan <shriramr@vmware.com>

* use new header match specifier

Signed-off-by: Shriram Rajagopalan <shriramr@vmware.com>
* sidecar health

Signed-off-by: Kuat Yessenov <kuat@google.com>

* typos

Signed-off-by: Kuat Yessenov <kuat@google.com>

* remove tracing of health checks

Signed-off-by: Kuat Yessenov <kuat@google.com>

* change to 15093

Signed-off-by: Kuat Yessenov <kuat@google.com>
* use new websocket option and remove deprecated one

Signed-off-by: Shriram Rajagopalan <shriramr@vmware.com>

* backward compatibility

Signed-off-by: Shriram Rajagopalan <shriramr@vmware.com>

* consistency

Signed-off-by: Shriram Rajagopalan <shriramr@vmware.com>

* cleanup

Signed-off-by: Shriram Rajagopalan <shriramr@vmware.com>

* dont append upgrade configs
it does not work, requires debugging and possibly implementation, will not be in time before the release
* dirty poc

* working poc

* comments + cleanup

* lint

* add simple e2e test to egress

* minor refactoring

* cleanups, lots of comments

Signed-off-by: Shriram Rajagopalan <shriramr@vmware.com>

* more duplication for clarity

Signed-off-by: Shriram Rajagopalan <shriramr@vmware.com>

* simplifying gateway opaque tcp logic

* final cleanups

Signed-off-by: Shriram Rajagopalan <shriramr@vmware.com>

* nil pointer check

Signed-off-by: Shriram Rajagopalan <shriramr@vmware.com>
* add tests for conditional and unknown quota

* add conditional and unknown quota
* enable upgrade config only for 1.0 proxy

Signed-off-by: Shriram Rajagopalan <shriramr@vmware.com>

* lint

Signed-off-by: Shriram Rajagopalan <shriramr@vmware.com>
* Fix log, add debounce

* If env is 0, disable debounce

* Add missing config file

* Safer code, failsafe

* Update comments and remove unused metrics

* Lower verbosity

* Increase quiet interval - k8s throttling seems to kick in, 100 ms too little

* Verbose message triggered for tcp services

* Format and adjust timer for debounce, a second was too long.

* Fix backward compat to 0.8
Kubernetes >=v1.11.0 will create two PriorityClass, including
system-cluster-critical and system-node-critical, it is better
to configure this in order to make sure your Istio pods will
not be killed because of low prioroty class.

Refer to https://kubernetes.io/docs/concepts/configuration/pod-priority-preemption/#priorityclass
for more detail.
…figuration (istio#7234)

* update galley to self-register and reconcile the validatingwebhookconfiguration

* bin/fmt.sh

* comment exported functions

* fix bug

* fix spelling in error message

* fix spelling error and rbac rules

* add explicit deletion of webhook configuration

* refactor code and improve cleanup handling

* update tmp change

* fix lint and format errors; clean-up dead code

* improve logging and fix config reload bug

* improve tests

* remove unused var

* remove explicit deletion of webhook configuration.

* add more comments and rename some functions
…istio#7260)

* Fix istio-remote sidecar-injector-configmap rendered yaml parse error

* Fix istio chart sidecar-injector-configmap rendered yaml parse error
Signed-off-by: Shriram Rajagopalan <shriramr@vmware.com>
* Do not allow short names in gateway hosts

Signed-off-by: Shriram Rajagopalan <shriramr@vmware.com>

* allow *

Signed-off-by: Shriram Rajagopalan <shriramr@vmware.com>

* lint

Signed-off-by: Shriram Rajagopalan <shriramr@vmware.com>
Merge release-1.0 into master
* Current changes to the stress test environment

* Remove old files
* Add keepalive

* Update golden
istio#6454)

- this aligns with current docs & preferred remote cluster config
  reference.
@codecov
Copy link
Copy Markdown

codecov bot commented Aug 17, 2018

Codecov Report

Merging #8041 into collab-gcp-identity will decrease coverage by 1%.
The diff coverage is 77%.

Impacted file tree graph

@@                  Coverage Diff                  @@
##           collab-gcp-identity   #8041     +/-   ##
=====================================================
- Coverage                   72%     72%    -<1%     
=====================================================
  Files                      358     367      +9     
  Lines                    30512   31875   +1363     
=====================================================
+ Hits                     21813   22690    +877     
- Misses                    7760    8201    +441     
- Partials                   939     984     +45
Impacted Files Coverage Δ
mixer/adapter/signalfx/signalfx.go 83% <ø> (+1%) ⬆️
mixer/pkg/server/server.go 93% <ø> (-1%) ⬇️
mixer/pkg/il/builder.go 100% <ø> (ø) ⬆️
mixer/pkg/il/opcode.go 100% <ø> (ø) ⬆️
mixer/pkg/runtime/dispatcher/session.go 94% <ø> (+2%) ⬆️
mixer/pkg/attribute/protoBag.go 100% <ø> (ø) ⬆️
mixer/pkg/config/crd/store.go 97% <ø> (-1%) ⬇️
mixer/pkg/config/mcp/conversion.go 80% <ø> (ø)
mixer/adapter/redisquota/redisquota.go 90% <ø> (-1%) ⬇️
mixer/adapter/signalfx/tracing.go 80% <ø> (ø)
... and 154 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c4db21...3c8a03b. Read the comment docs.

@googlebot
Copy link
Copy Markdown
Collaborator

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

@googlebot googlebot added the cla: no Set by the Google CLA bot to indicate the author of a PR has not signed the Google CLA. label Aug 17, 2018
@quanjielin
Copy link
Copy Markdown
Contributor Author

/test e2e-bookInfo-envoyv2-v1alpha3

@istio-testing
Copy link
Copy Markdown
Collaborator

@quanjielin: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
prow/e2e-bookInfoTests-v1alpha3.sh 3c8a03b link /test e2e-bookInfo-envoyv2-v1alpha3
Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@googlebot
Copy link
Copy Markdown
Collaborator

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

@googlebot googlebot removed the cla: no Set by the Google CLA bot to indicate the author of a PR has not signed the Google CLA. label Aug 17, 2018
@quanjielin
Copy link
Copy Markdown
Contributor Author

should be safe to merge, @hklai could you pls help to merge ?

  1. failure on e2e-bookInfo-envoyv2-v1alpha3 is known issue e2e-bookInfoTests-v1alpha3 is consistently failing in both release-1.0 and master #8046, which isn't caused by this PR
  2. verified our provision workflow works e2e

/cc @wattli @incfly

@istio-testing istio-testing requested review from incfly and wattli August 17, 2018 23:50
@quanjielin quanjielin requested a review from hklai August 17, 2018 23:50
@incfly
Copy link
Copy Markdown

incfly commented Aug 18, 2018

Great!

@hklai to provide some context, we need this to be as commit merge in order to not confuse git when merging back into master.

@hklai hklai merged commit dbb7dfc into istio:collab-gcp-identity Aug 18, 2018
quanjielin added a commit to quanjielin/istio that referenced this pull request Aug 22, 2018
quanjielin added a commit that referenced this pull request Aug 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.