Add test for TCP Metrics#741
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Assign the PR to them by writing The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these OWNERS Files:You can indicate your approval by writing |
|
@douglas-reid PR needs rebase |
|
@douglas-reid: The following test failed, say
DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
ldemailly
left a comment
There was a problem hiding this comment.
would be good to stick to 2 reviews in the next couple of days
| } | ||
|
|
||
| func TestTcpMetrics(t *testing.T) { | ||
| if err := replaceRouteRule(tcpDbRule); err != nil { |
There was a problem hiding this comment.
ah nice, this is the test mentioned in the other PR, sorry somehow I didn't see that PR until now
(don't hesitate to ping me in the future if I don't comment on a PR before it gets merged)
| fatalf(t, "Could not find metric value: %v", err) | ||
| } | ||
| t.Logf("tcp_bytes_sent: %f", got) | ||
| want := float64(1) |
There was a problem hiding this comment.
the reply is bigger than 1 byte no ?
| fatalf(t, "Could not find metric value: %v", err) | ||
| } | ||
| t.Logf("tcp_bytes_received: %f", got) | ||
| if got < want { |
| } | ||
| glog.Infof("promvalue := %s", value.String()) | ||
|
|
||
| got, err := vectorValue(value, map[string]string{}) |
There was a problem hiding this comment.
shouldn't there be a subtraction of the previous value here too ?
(maybe that could be a function to delta the stats - or I missed a refactor and it already does that ?)
* Add test for TCP Metrics * versioned selection * Do not duplicate destination attributes * no more target Former-commit-id: 9c53d52
* Add test for TCP Metrics * versioned selection * Do not duplicate destination attributes * no more target Former-commit-id: 9c53d52
* Add test for TCP Metrics * versioned selection * Do not duplicate destination attributes * no more target Former-commit-id: 9c53d52
* fix iop status update issue. * fix lint. * update status with instance upadter. * add back the status subresource. * move status out of spec.
* Introduce forward looking MCP enhancements The initial version of Mesh Configuration Protocol (MCP) was introduced to decouple Pilot/Mixer from the k8s kube-apiserver. These enhancements address additional forward looking requirements as we bring Galley and the MCP API to beta quality. * Enable alternative control topologies where the source of configuration is not publicly accessible. * Provide a feedback mechanism to report the observed config state to the user (e.g via CRD status). * Improve performance at scale (e.g. Enterprise use case) * Rationalize the resource model The intent is to introduce these backwards incompatible API changes now before Galley and MCP ship as beta quality and on-by-default. Rationalization of the resource model and incremental improvements can be implemented immediately as they effect the contract between Pilot and Galley. Alternative control topologies and feedback/status are inherently new features and can be implemented later with the same APIs without concerns of breaking compatibility. Design proposal: https://goo.gl/RTKMwF * fix linter error * add missing generated file * proto-commit * remove python/istio_api/mcp/v1alpha1/envelope_pb2.py * s/envelope/resource * s/client/node * make proto-commit * fix comments * add system_version_info for compatibility with non-incremental MCP * address review comments * s/node/sink_node * address more review comments * update resource name documentation
This PR adds a basic test to check that TCP metrics can be generated for TCP services. It uses the bookinfo sample app, including the mongodb service.
It also adds:
Release note: