Merged
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Assign the PR to them by writing The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these OWNERS Files:You can indicate your approval by writing |
yutongz
reviewed
Sep 11, 2017
tests/e2e/framework/kubernetes.go
Outdated
| if *rbacfile != "" { | ||
| baseRbacYaml := util.GetResourcePath(*rbacfile) | ||
| testRbacYaml := filepath.Join(k.TmpDir, "yaml", filepath.Base(*rbacfile)) | ||
| if err := k.generateRbac(baseRbacYaml, testRbacYaml); err != nil { |
Contributor
There was a problem hiding this comment.
You don't need to generate it again. You just need to check if testRbacYaml is there. If yes, kubeDelete it.
yutongz
approved these changes
Sep 11, 2017
rshriram
pushed a commit
that referenced
this pull request
Oct 30, 2017
* Clean up ClusterRoleBindings * Fix linter * Check file exists Former-commit-id: 64198ed
vbatts
pushed a commit
to vbatts/istio
that referenced
this pull request
Oct 31, 2017
* Clean up ClusterRoleBindings * Fix linter * Check file exists Former-commit-id: 64198ed
mandarjog
pushed a commit
that referenced
this pull request
Nov 2, 2017
* Clean up ClusterRoleBindings * Fix linter * Check file exists Former-commit-id: 64198ed
kyessenov
pushed a commit
to kyessenov/istio
that referenced
this pull request
Aug 13, 2018
Automatic merge from submit-queue. [DO NOT MERGE] Auto PR to update dependencies of proxy This PR will be merged automatically once checks are successful. ```release-note none ```
howardjohn
pushed a commit
to howardjohn/istio
that referenced
this pull request
Jan 12, 2020
* Set CNI namespace as kube-system Signed-off-by: Chun Lin Yang <clyang@cn.ibm.com> * Fix test failure issues
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes istio/old_pilot_repo#1239
The only cleanup done by the tests is to delete the namespaces, but this leaves behind resources which are not namespaced, like ClusterRoleBinding.
Added code to delete them.
Matches istio/old_pilot_repo#1240