Merged
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Assign the PR to them by writing The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these OWNERS Files:You can indicate your approval by writing |
ldemailly
reviewed
Sep 7, 2017
| ln -sf ${GOPATH}/src/github.com/istio ${GOPATH}/src/istio.io | ||
| cd ${GOPATH}/src/istio.io/istio | ||
| if [[ ! $PWD = ${GOPATH}/src/istio.io/istio ]]; then | ||
| # Test harness will checkout code to directory $GOPATH/src/github.com/istio/istio |
Member
There was a problem hiding this comment.
shouldn't that be configurable ? it's pretty standard to have foo.io instead of github.com - it could read the CNAME for instance
Contributor
Author
There was a problem hiding this comment.
Can we do something smarter later maybe and use this for now :)
sebastienvas
approved these changes
Sep 7, 2017
Collaborator
|
@yutongz: The following tests failed, say
DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
mandarjog
pushed a commit
to mandarjog/istio
that referenced
this pull request
Oct 30, 2017
* Introduce redis backend for config store. Note: this implements the exact SPI currently we have. With some redis features, some things (like listening updates) can be done more efficiently, but that needs to change the SPI. I'll address that after landing this. * review fixes. * Fix the key length cache. * lint fixes * more lint checks. * fix usage of log module. Former-commit-id: 123a1f3932bb222f2347c0ae04a4b4d134c59c32
mandarjog
pushed a commit
that referenced
this pull request
Oct 31, 2017
* Introduce redis backend for config store. Note: this implements the exact SPI currently we have. With some redis features, some things (like listening updates) can be done more efficiently, but that needs to change the SPI. I'll address that after landing this. * review fixes. * Fix the key length cache. * lint fixes * more lint checks. * fix usage of log module. Former-commit-id: 72388028a804f52967e8cc88b575cb137fb0155e
vbatts
pushed a commit
to vbatts/istio
that referenced
this pull request
Oct 31, 2017
Former-commit-id: 664f659
0x01001011
pushed a commit
to thedemodrive/istio
that referenced
this pull request
Jul 16, 2020
in the latest envoyproxy.io (1.9) api-v1 was removed
luksa
pushed a commit
to luksa/istio
that referenced
this pull request
Apr 11, 2024
* OSSM-742 Improve Maistra container images build (for maistra-2.3) (istio#606) * OSSM-742 Improve Maistra container images build (istio#534) * OSSM-742 Improve Maistra container images build * Simplify make rules and Dockerfiles * Fix dockerfiles lint issues * Reorganize files and apply image naming convention * Update MAISTRA_VERSION and ISTIO_VERSION * Adapt images builds relying on upstream build tool * Add copyright and license into scripts * chore: updates image labels to reflect actual targeted versions * chore: removes vendor left-overs Co-authored-by: bmangoen <bmangoen@gmail.com>
dgn
pushed a commit
to dgn/istio
that referenced
this pull request
Jun 13, 2024
* OSSM-742 Improve Maistra container images build (for maistra-2.3) (istio#606) * OSSM-742 Improve Maistra container images build (istio#534) * OSSM-742 Improve Maistra container images build * Simplify make rules and Dockerfiles * Fix dockerfiles lint issues * Reorganize files and apply image naming convention * Update MAISTRA_VERSION and ISTIO_VERSION * Adapt images builds relying on upstream build tool * Add copyright and license into scripts * chore: updates image labels to reflect actual targeted versions * chore: removes vendor left-overs Co-authored-by: bmangoen <bmangoen@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release note: