[DO NOT MERGE] Auto PR to update dependencies of istio#688
Closed
istio-testing wants to merge 1 commit intomasterfrom
Closed
[DO NOT MERGE] Auto PR to update dependencies of istio#688istio-testing wants to merge 1 commit intomasterfrom
istio-testing wants to merge 1 commit intomasterfrom
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Assign the PR to them by writing The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these OWNERS Files:You can indicate your approval by writing |
Collaborator
Author
|
@istio-testing: The following tests failed, say
DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
howardjohn
added a commit
to howardjohn/istio
that referenced
this pull request
Jan 12, 2020
We cannot be cloning from github blindly, as this will break our private security builds. This PR adds an option to pass an INSTALLER_DIR option to the scripts and skip the cloning. Additionally, do not run vfsgen when you do docker build. This should be an explicit step, otherwise the code magically changes during a build and you spend all day debugging it.
luksa
added a commit
to luksa/istio
that referenced
this pull request
Apr 11, 2024
…Istio CNI (istio#688) * [cni] MAISTRA-2132 Support deployment of multiple plugin versions in Istio CNI (istio#271) Includes: * MAISTRA-2135 Add unit tests for our CNI binary-prefix work (istio#325) * MAISTRA-2137 Make network namespace setup executable name configurable (istio#273) To support the deployment of multiple CNI plugin versions, the name of the executable that is invoked to set up the network namespace must be configurable. * OSSM-1430: CNI: Watch for modified files with a prefix (istio#510) Because our CNI pod contains more than one container, and they write to the same directory, and they watch for changes on those directories, changes made by one container trigger the watch on the other, which will responde by copying the files to the directory, which will in turn trigger the watcher of the other container in an endless loop. This leads to high CPU usage on the node. This PR changes the logic to only monitor for files that have the desired prefix. Thus, for example, the 2.2 container will only react to changes to files whose names start with "v2-2". This avoid this race condition and achieve the same end result. * [cni] MAISTRA-2051 use correct UID/GID in istio-iptables * OSSM-2082 CNI installer now creates the net.d directory if necessary (istio#638) * fix(lint): replaces deprecated pkg io/ioutil * fix: reverts back to t.TempDir() calls Co-authored-by: Marko Lukša <marko.luksa@gmail.com> Co-authored-by: rcernich <rcernich@redhat.com>
dgn
pushed a commit
to dgn/istio
that referenced
this pull request
Jun 13, 2024
…Istio CNI (istio#688) * [cni] MAISTRA-2132 Support deployment of multiple plugin versions in Istio CNI (istio#271) Includes: * MAISTRA-2135 Add unit tests for our CNI binary-prefix work (istio#325) * MAISTRA-2137 Make network namespace setup executable name configurable (istio#273) To support the deployment of multiple CNI plugin versions, the name of the executable that is invoked to set up the network namespace must be configurable. * OSSM-1430: CNI: Watch for modified files with a prefix (istio#510) Because our CNI pod contains more than one container, and they write to the same directory, and they watch for changes on those directories, changes made by one container trigger the watch on the other, which will responde by copying the files to the directory, which will in turn trigger the watcher of the other container in an endless loop. This leads to high CPU usage on the node. This PR changes the logic to only monitor for files that have the desired prefix. Thus, for example, the 2.2 container will only react to changes to files whose names start with "v2-2". This avoid this race condition and achieve the same end result. * [cni] MAISTRA-2051 use correct UID/GID in istio-iptables * OSSM-2082 CNI installer now creates the net.d directory if necessary (istio#638) * fix(lint): replaces deprecated pkg io/ioutil * fix: reverts back to t.TempDir() calls Co-authored-by: Marko Lukša <marko.luksa@gmail.com> Co-authored-by: rcernich <rcernich@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR will be merged automatically once checks are successful.