Enforce Kubernetes RBAC at all times#6657
Merged
istio-testing merged 1 commit intoistio:masterfrom Jun 27, 2018
Merged
Conversation
This removes the capability of disabling Kubernetes RBAC in the deployment of Istio. The reason this option was originally added is that RBAC was pretty rough around the edges in Kubernetes 1.6 and 1.7. In later Kubernetes versions, RBAC worked well and is completely integrated with Istio. RBAC has been enabled since Istio 0.8. This PR forces RBAC to enabled by removing the conditional for RBAC disablement.
Member
|
/lgtm |
Collaborator
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rshriram, sdake The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Collaborator
|
@sdake: The following tests failed, say
DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
quanjielin
pushed a commit
to quanjielin/istio
that referenced
this pull request
Jul 2, 2018
This removes the capability of disabling Kubernetes RBAC in the deployment of Istio. The reason this option was originally added is that RBAC was pretty rough around the edges in Kubernetes 1.6 and 1.7. In later Kubernetes versions, RBAC worked well and is completely integrated with Istio. RBAC has been enabled since Istio 0.8. This PR forces RBAC to enabled by removing the conditional for RBAC disablement.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes the capability of disabling Kubernetes RBAC
in the deployment of Istio. The reason this option was
originally added is that RBAC was pretty rough around the
edges in Kubernetes 1.6 and 1.7. In later Kubernetes
versions, RBAC worked well and is completely integrated with
Istio.
RBAC has been enabled since Istio 0.8. This PR forces
RBAC to enabled by removing the conditional for RBAC disablement.