Revert "Use downstream protocol by default (#6158)"#6611
Revert "Use downstream protocol by default (#6158)"#6611rshriram merged 1 commit intoistio:masterfrom
Conversation
It's forcing HTTP protocol version negotiated on the downstream to all the peers along the way, even though there is no guarantee that any of them supports it. This reverts commit ef5ad46. Fixes istio#6421. Signed-off-by: Piotr Sikora <piotrsikora@google.com>
|
cc @Nino-K, since I was unable to add you to reviewers. |
|
This is going to fail our Cloud Foundry use case - which needs h2 -> h2 (via a gateway). If we are going to revert this, I am going to have to go back and let everyone know who was already testing this. |
|
@zachgersh why can't you simply configure gateway to backend leg to use HTTP/2? |
|
per offline convo, @zachgersh / CF folks are going to name the ports as http2 to get h2->h2 behavior |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nmittler, PiotrSikora, rshriram The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
It's forcing HTTP protocol version negotiated on the downstream to all the peers along the way, even though there is no guarantee that any of them supports it. This reverts commit ef5ad46. Fixes istio#6421. Signed-off-by: Piotr Sikora <piotrsikora@google.com>
It's forcing HTTP protocol version negotiated on the downstream to all
the peers along the way, even though there is no guarantee that any of
them supports it.
This reverts commit ef5ad46.
Fixes #6421.
Signed-off-by: Piotr Sikora piotrsikora@google.com