Skip to content

Fix yaml file templates#644

Merged
ldemailly merged 2 commits intoistio:masterfrom
myidpt:ingressfix
Sep 2, 2017
Merged

Fix yaml file templates#644
ldemailly merged 2 commits intoistio:masterfrom
myidpt:ingressfix

Conversation

@myidpt
Copy link
Copy Markdown

@myidpt myidpt commented Sep 2, 2017

Release note:

NONE

@myidpt
Copy link
Copy Markdown
Author

myidpt commented Sep 2, 2017 •
edited
Loading

@ldemailly PTAL

@andraxylia
Copy link
Copy Markdown
Contributor

andraxylia commented Sep 2, 2017

/lgtm

@myidpt
Copy link
Copy Markdown
Author

myidpt commented Sep 2, 2017

The only diff is that the secret creation section in istio-auth-with-cluster-ca.yaml is moved up. Please let me know if you think this should also be fixed.

@ldemailly
Copy link
Copy Markdown
Member

ldemailly commented Sep 2, 2017

doesn't matter if it's functionally equivalent

do you mind changing the header as we talked about ?

@myidpt
Copy link
Copy Markdown
Author

myidpt commented Sep 2, 2017

It's updated now.

@istio-merge-robot
Copy link
Copy Markdown

istio-merge-robot commented Sep 2, 2017

/lgtm cancel //PR changed after LGTM, removing LGTM. @andraxylia @myidpt

ldemailly
ldemailly approved these changes Sep 2, 2017
View reviewed changes
Copy link
Copy Markdown
Member

@ldemailly ldemailly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@ldemailly
Copy link
Copy Markdown
Member

ldemailly commented Sep 2, 2017

/lgtm

@istio-merge-robot
Copy link
Copy Markdown

istio-merge-robot commented Sep 2, 2017

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andraxylia, ldemailly

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these OWNERS Files:
  • OWNERS [andraxylia,ldemailly]

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@ldemailly ldemailly merged commit df25e93 into istio:master Sep 2, 2017
@myidpt myidpt deleted the ingressfix branch September 2, 2017 03:23
@ldemailly ldemailly mentioned this pull request Sep 2, 2017
Closed
@istio-testing
Copy link
Copy Markdown
Collaborator

istio-testing commented Sep 2, 2017

@myidpt: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
prow/e2e-suite-rbac-auth.sh 2376af4 link /test e2e-suite-rbac-auth
prow/e2e-suite-no_rbac-auth.sh 2376af4 link /test e2e-suite-no_rbac-auth
Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

rshriram pushed a commit that referenced this pull request Oct 30, 2017
@ldemailly
Fix yaml file templates (#644)
4d165c4 
* Fix template.

* Small fix.


Former-commit-id: df25e93
vbatts pushed a commit to vbatts/istio that referenced this pull request Oct 31, 2017
@ldemailly
Fix yaml file templates (istio#644)
2c4be97 
* Fix template.

* Small fix.


Former-commit-id: df25e93
mandarjog pushed a commit that referenced this pull request Nov 2, 2017
@ldemailly
Fix yaml file templates (#644)
881092c 
* Fix template.

* Small fix.


Former-commit-id: df25e93
howardjohn pushed a commit to howardjohn/istio that referenced this pull request Jan 12, 2020
@bianpengyuan @istio-testing
r/envoy_boostrap/custom_bootstrap (istio#644)
89b2fe6
howardjohn pushed a commit to howardjohn/istio that referenced this pull request Jan 12, 2020
@irisdingbj @istio-testing
Export methods for GenManifest and MakeTreeFromSetList (istio#644)
6a46e6d
0x01001011 pushed a commit to thedemodrive/istio that referenced this pull request Jul 16, 2020
@venilnoronha @rshriram
Update weighted cluster support docs in TCP/TLS (istio#644)
9dc4a30 
Signed-off-by: Venil Noronha <veniln@vmware.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@ldemailly ldemailly ldemailly approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@ldemailly ldemailly

@andraxylia andraxylia

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@myidpt @andraxylia @ldemailly @istio-merge-robot @istio-testing @googlebot