Skip to content

[DO NOT MERGE] Auto PR to update dependencies of istio#602

Merged
istio-merge-robot merged 1 commit intomasterfrom
autoUpdateDeps_2d9224bc2d8eb0fcc7098620a6c1179a
Aug 26, 2017
Merged

[DO NOT MERGE] Auto PR to update dependencies of istio#602
istio-merge-robot merged 1 commit intomasterfrom
autoUpdateDeps_2d9224bc2d8eb0fcc7098620a6c1179a

Conversation

@istio-testing
Copy link
Copy Markdown
Collaborator

@istio-testing istio-testing commented Aug 26, 2017

This PR will be merged automatically once checks are successful.

@istio-merge-robot
Copy link
Copy Markdown

istio-merge-robot commented Aug 26, 2017

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
We suggest the following additional approver: andraxylia

Assign the PR to them by writing /assign @andraxylia in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@istio-merge-robot
Copy link
Copy Markdown

istio-merge-robot commented Aug 26, 2017

/test all [submit-queue is verifying that this PR is safe to merge]

@istio-merge-robot
Copy link
Copy Markdown

istio-merge-robot commented Aug 26, 2017

Automatic merge from submit-queue

@sebastienvas
Copy link
Copy Markdown
Contributor

sebastienvas commented Aug 26, 2017

@chxchx @yutongz - I added istio-testing as user who can skip code review. Let's see if this go thru.

@istio-merge-robot
Copy link
Copy Markdown

istio-merge-robot commented Aug 26, 2017

/test all [submit-queue is verifying that this PR is safe to merge]

@istio-merge-robot
Copy link
Copy Markdown

istio-merge-robot commented Aug 26, 2017

Automatic merge from submit-queue

@istio-merge-robot
Copy link
Copy Markdown

istio-merge-robot commented Aug 26, 2017

/test all [submit-queue is verifying that this PR is safe to merge]

@istio-merge-robot
Copy link
Copy Markdown

istio-merge-robot commented Aug 26, 2017

Automatic merge from submit-queue

@sebastienvas
Copy link
Copy Markdown
Contributor

sebastienvas commented Aug 26, 2017

I am not convinced this is the approval since istio-testing can skip it. I believe is the timing between prow and submit queue. Since we start presubmit and then trigger on success job, there is brief moment of time where everything is green, but I believe that by the time submit queue tries to merge, the e2e-suite is still pending.

PR state:
presubmit - OK
e2e-suite - OK

Submit queue says test all
presubmit - Pending
e2e-suite - OK

Presubmit completes
presubmit - OK
e2e-suite - OK (for a brief time)

Submit Q tries to submit
presubmit - OK
e2e-suite - Pending

submit retries its forever loop. To prove this theory I'll approve the PR myself.

@istio-merge-robot
Copy link
Copy Markdown

istio-merge-robot commented Aug 26, 2017

/test all [submit-queue is verifying that this PR is safe to merge]

@istio-merge-robot
Copy link
Copy Markdown

istio-merge-robot commented Aug 26, 2017

Automatic merge from submit-queue

@istio-merge-robot istio-merge-robot merged commit 7632394 into master Aug 26, 2017
@sebastienvas
Copy link
Copy Markdown
Contributor

sebastienvas commented Aug 26, 2017

This is confusing.

@sebastienvas
Copy link
Copy Markdown
Contributor

sebastienvas commented Aug 26, 2017 •
edited
Loading

ok dismiss review is not what I was thinking. you can dismiss an old review but you still need approval. So I guess if we keep applying this on admin, we cannot have the bot merge stuff without approval like @yutongz stated.

@istio-testing
Copy link
Copy Markdown
Collaborator Author

istio-testing commented Aug 26, 2017

@istio-testing: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
prow/e2e-suite-no_rbac-auth.sh cad1649 link /test e2e-suite-no_rbac-auth
prow/e2e-suite-rbac-auth.sh cad1649 link /test e2e-suite-rbac-auth
Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@yutongz
Copy link
Copy Markdown
Contributor

yutongz commented Aug 26, 2017

In that case I guess the possible solutions could be we limits the admins for istio/istio and allow those including robot to merge without review. Or we have a robot to do github approval for all these prs.

@rshriram rshriram deleted the autoUpdateDeps_2d9224bc2d8eb0fcc7098620a6c1179a branch September 12, 2017 02:36
mandarjog pushed a commit to mandarjog/istio that referenced this pull request Oct 30, 2017
@douglas-reid
Add initial statsd support for duration distributions (istio#602)
4cf025d 
* Add initial statsd support for duration distributions


Former-commit-id: 9ea6995b9378b1b21fc6c17f40d810f5a2aa7607
rshriram pushed a commit that referenced this pull request Oct 30, 2017
@istio-testing @istio-merge-robot
Update_Dependencies (#602)
3af0b04 
Automatic merge from submit-queue

[DO NOT MERGE] Auto PR to update dependencies of istio

This PR will be merged automatically once checks are successful.

Former-commit-id: 7632394
mandarjog pushed a commit that referenced this pull request Oct 31, 2017
@douglas-reid
Add initial statsd support for duration distributions (#602)
2a43950 
* Add initial statsd support for duration distributions


Former-commit-id: 4ac11f7da4f73cf099d339c3b7ce85b177f89338
vbatts pushed a commit to vbatts/istio that referenced this pull request Oct 31, 2017
@istio-testing @istio-merge-robot
Update_Dependencies (istio#602)
428eecc 
Automatic merge from submit-queue

[DO NOT MERGE] Auto PR to update dependencies of istio

This PR will be merged automatically once checks are successful.

Former-commit-id: 7632394
mandarjog pushed a commit that referenced this pull request Nov 2, 2017
@istio-testing @istio-merge-robot
Update_Dependencies (#602)
ba8adeb 
Automatic merge from submit-queue

[DO NOT MERGE] Auto PR to update dependencies of istio

This PR will be merged automatically once checks are successful.

Former-commit-id: 7632394
howardjohn added a commit to howardjohn/istio that referenced this pull request Jan 12, 2020
@howardjohn @istio-testing
Move telemetry out of pilot (istio#602)
cd4d0c7 
* Move telemetry out of pilot

* Update
0x01001011 pushed a commit to thedemodrive/istio that referenced this pull request Jul 16, 2020
@yangminzhu @istio-testing
Hide peer_is_optional and origin_is_optional from docs for later depr…
fe4a677 
…ecation (istio#602)

* Hide peer_is_optional and origin_is_optional from docs for later deprecation.

* update
luksa pushed a commit to luksa/istio that referenced this pull request Sep 15, 2022
@jewertow
Revert removal of multi-arch node selector in gateways (istio#602)
f418472 
* Revert "delete multi-arch selector in the gateway templates (istio#40107)"

This reverts commit 69a026f.

* Remove failing tests of "istioctl experimental remove-from-mesh"

Signed-off-by: Jacek Ewertowski <jewertow@redhat.com>

Signed-off-by: Jacek Ewertowski <jewertow@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@sebastienvas sebastienvas sebastienvas approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

dependency-update

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@istio-testing @istio-merge-robot @sebastienvas @yutongz @googlebot