Skip to content

chore: remove comments about MaxRequests or MaxPendingRequests only applying to particular HTTP version#57705

Merged
istio-testing merged 1 commit intoistio:masterfrom
frittentheke:cbHTTPver
Sep 20, 2025
Merged

chore: remove comments about MaxRequests or MaxPendingRequests only applying to particular HTTP version#57705
istio-testing merged 1 commit intoistio:masterfrom
frittentheke:cbHTTPver

Conversation

@frittentheke
Copy link
Copy Markdown
Contributor

@frittentheke frittentheke commented Sep 19, 2025 •
edited
Loading

Please provide a description of this PR:

The circuit-breaker connection pool settings MaxRequestsand MaxPendingRequests apply to HTTP/1.1 as well as HTTP/2 since [1] and [2].

This was actually changed in the Istio docs via [3], but these source code comments were left, potentially causing confusion.

[1] envoyproxy/envoy#9215
[2] envoyproxy/envoy#9668
[3] istio/api#2428

@frittentheke
chore: remove comments about MaxRequests or MaxPendingRequests only a…
d3bc135 
…pplying to particular HTTP version

The circuit-breaker connection pool settings `MaxRequests`and `MaxPendingRequests` apply to HTTP/1.1
as well as HTTP/2 since [1] and [2].

This was actually changed in the Istio docs via [3], but these source code comments were left, potentially
causing confusion.

[1] envoyproxy/envoy#9215
[2] envoyproxy/envoy#9668
[3] istio/api#2428

Signed-off-by: Christian Rohmann <christian.rohmann@inovex.de>
@frittentheke frittentheke requested a review from a team as a code owner September 19, 2025 07:23
@istio-policy-bot istio-policy-bot added kind/docs release-notes-none Indicates a PR that does not require release notes. labels Sep 19, 2025
@istio-policy-bot
Copy link
Copy Markdown

istio-policy-bot commented Sep 19, 2025

😊 Welcome @frittentheke! This is either your first contribution to the Istio istio repo, or it's been
a while since you've been here.

You can learn more about the Istio working groups, Code of Conduct, and contribution guidelines
by referring to Contributing to Istio.

Thanks for contributing!

Courtesy of your friendly welcome wagon.

@istio-testing istio-testing added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 19, 2025
@istio-testing
Copy link
Copy Markdown
Collaborator

istio-testing commented Sep 19, 2025

Hi @frittentheke. Thanks for your PR.

I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ramaraochavali
Copy link
Copy Markdown
Contributor

ramaraochavali commented Sep 19, 2025

/ok-to-test

@istio-testing istio-testing added ok-to-test Set this label allow normal testing to take place for a PR not submitted by an Istio org member. and removed needs-ok-to-test labels Sep 19, 2025
@frittentheke
Copy link
Copy Markdown
Contributor Author

frittentheke commented Sep 19, 2025

/test integ-ambient-nftables

@istio-testing
Copy link
Copy Markdown
Collaborator

istio-testing commented Sep 19, 2025 •
edited
Loading

@frittentheke: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
integ-ambient-nftables_istio d3bc135 link false /test integ-ambient-nftables
Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@frittentheke
Copy link
Copy Markdown
Contributor Author

frittentheke commented Sep 20, 2025

Is there anything I can do to have the test pass?

@sridhargaddam
Copy link
Copy Markdown
Contributor

sridhargaddam commented Sep 20, 2025

integ-ambient-nftables

You can ignore the integ-ambient-nftables as its optional. The integ-ambient-dual seems to be flaky, let me re-trigger it.

@sridhargaddam
Copy link
Copy Markdown
Contributor

sridhargaddam commented Sep 20, 2025

/test integ-ambient-dual

@istio-testing istio-testing merged commit 810d269 into istio:master Sep 20, 2025
32 of 33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@howardjohn howardjohn howardjohn approved these changes

Assignees

No one assigned

Labels

kind/docs ok-to-test Set this label allow normal testing to take place for a PR not submitted by an Istio org member. release-notes-none Indicates a PR that does not require release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@frittentheke @istio-policy-bot @istio-testing @ramaraochavali @sridhargaddam @howardjohn