Skip to content

circuit breaking: Change max_requests to work for both HTTP/1 and HTTP/2 #9215

@tonya11en

Description

@tonya11en

The current way circuit breakers are used to limit outstanding requests involves using max_requests for HTTP/2 and max_connections for HTTP/1. This is unintuitive and and requires special handling for code that requires knowledge of the number of outstanding requests (such as retry budgets).

I'd like to propose altering the way we increment outstanding requests in the per-cluster resource managers to track requests between both HTTPs. This would allow users to simply set max_requests circuit breaker values and be agnostic to the HTTP version.

This is particularly risky because it's a subtle change in behavior for widely used parameters. Hiding this behavior behind a feature flag would certainly be necessary, but I'll defer to maintainers/community on the best approach to making a change like this (if it's desired).

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementFeature requests. Not bugs or questions.help wantedNeeds help!

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions