-
Notifications
You must be signed in to change notification settings - Fork 5.3k
Description
The current way circuit breakers are used to limit outstanding requests involves using max_requests for HTTP/2 and max_connections for HTTP/1. This is unintuitive and and requires special handling for code that requires knowledge of the number of outstanding requests (such as retry budgets).
I'd like to propose altering the way we increment outstanding requests in the per-cluster resource managers to track requests between both HTTPs. This would allow users to simply set max_requests circuit breaker values and be agnostic to the HTTP version.
This is particularly risky because it's a subtle change in behavior for widely used parameters. Hiding this behavior behind a feature flag would certainly be necessary, but I'll defer to maintainers/community on the best approach to making a change like this (if it's desired).