Skip to content

Update istioctl x describe examples and remove dead code.#56643

Merged
istio-testing merged 1 commit intoistio:masterfrom
onecer:master
Jun 16, 2025
Merged

Update istioctl x describe examples and remove dead code.#56643
istio-testing merged 1 commit intoistio:masterfrom
onecer:master

Conversation

@onecer
Copy link
Copy Markdown
Contributor

@onecer onecer commented Jun 14, 2025 •
edited by istio-policy-bot
Loading

Please provide a description of this PR:

  • be specific istioctl x describe example
  • remove duplicate code

@onecer onecer requested review from a team as code owners June 14, 2025 19:24
@istio-policy-bot istio-policy-bot added kind/docs release-notes-none Indicates a PR that does not require release notes. labels Jun 14, 2025
@istio-policy-bot
Copy link
Copy Markdown

istio-policy-bot commented Jun 14, 2025

😊 Welcome @onecer! This is either your first contribution to the Istio istio repo, or it's been
a while since you've been here.

You can learn more about the Istio working groups, Code of Conduct, and contribution guidelines
by referring to Contributing to Istio.

Thanks for contributing!

Courtesy of your friendly welcome wagon.

@istio-testing istio-testing added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. needs-ok-to-test labels Jun 14, 2025
@istio-testing
Copy link
Copy Markdown
Collaborator

istio-testing commented Jun 14, 2025

Hi @onecer. Thanks for your PR.

I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@zirain
Copy link
Copy Markdown
Member

zirain commented Jun 15, 2025

/ok-to-test

@istio-testing istio-testing added ok-to-test Set this label allow normal testing to take place for a PR not submitted by an Istio org member. and removed needs-ok-to-test labels Jun 15, 2025
hanxiaop
hanxiaop reviewed Jun 15, 2025
View reviewed changes
@onecer
Update istioctl x describe examples and remove dead code.
e39f103 
Signed-off-by: Onecer <yinyongyou@gmail.com>
@istio-testing istio-testing added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 15, 2025
@istio-testing istio-testing merged commit 61611e7 into istio:master Jun 16, 2025
30 checks passed
@my-git9 my-git9 mentioned this pull request Jul 10, 2025
Merged
fjglira pushed a commit to fjglira/istio that referenced this pull request Sep 26, 2025
Automator: merge upstream changes to openshift-service-mesh/istio@master
58122cb 
* upstream/master:
  Update istioctl x describe examples and remove dead code. (istio#56643)
  addons: Bump addons version (istio#56648)
  Automator: update proxy@master in istio/istio@master (istio#56649)
  Automator: update proxy@master in istio/istio@master (istio#56635)
  Automator: update go-control-plane in istio/istio@master (istio#56646)
  fix: fixes flaky 'invalid crl' test case (istio#56634)
  Automator: update proxy@master in istio/istio@master (istio#56631)
  Automator: update proxy@master in istio/istio@master (istio#56625)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hanxiaop hanxiaop hanxiaop approved these changes

Assignees

No one assigned

Labels

kind/docs ok-to-test Set this label allow normal testing to take place for a PR not submitted by an Istio org member. release-notes-none Indicates a PR that does not require release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@onecer @istio-policy-bot @istio-testing @zirain @hanxiaop