Skip to content

(Linters) Adding missing --update which should ...#565

Merged
ldemailly merged 2 commits intomasterfrom
ldemailly-linter-repro
Aug 15, 2017
Merged

(Linters) Adding missing --update which should ...#565
ldemailly merged 2 commits intomasterfrom
ldemailly-linter-repro

Conversation

@ldemailly
Copy link
Copy Markdown
Member

@ldemailly ldemailly commented Aug 15, 2017

(Linters) Adding missing --update which should enhance the chance that
everyone sees the same/latest linter errors

Always run updated linters

(Linters) Adding missing --update which should enhance the chance that
everyone sees the same/latest linter errors
@ldemailly
Copy link
Copy Markdown
Member Author

@andraxylia
Copy link
Copy Markdown
Contributor

/approve no-issue

@sebastienvas
Copy link
Copy Markdown
Contributor

/lgtm

@istio-merge-robot
Copy link
Copy Markdown

Adding do-not-merge because the release note process has not been followed.
One of the following labels is required "release-note", "release-note-action-required", "release-note-experimental" or "release-note-none".
Please see: https://github.com/kubernetes/kubernetes/blob/master/docs/devel/pull-requests.md#release-notes.

@istio-merge-robot istio-merge-robot added the do-not-merge Block automatic merging of a PR. label Aug 15, 2017
@istio-merge-robot
Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andraxylia, ldemailly, sebastienvas

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these OWNERS Files:
  • OWNERS [andraxylia,ldemailly]

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@sebastienvas
Copy link
Copy Markdown
Contributor

/test all

@ldemailly ldemailly merged commit 5752eab into master Aug 15, 2017
@ldemailly ldemailly deleted the ldemailly-linter-repro branch August 15, 2017 22:09
rshriram pushed a commit that referenced this pull request Oct 30, 2017
(Linters) Adding missing --update which should enhance the chance that
everyone sees the same/latest linter errors

Former-commit-id: 5752eab
vbatts pushed a commit to vbatts/istio that referenced this pull request Oct 31, 2017
(Linters) Adding missing --update which should enhance the chance that
everyone sees the same/latest linter errors

Former-commit-id: 5752eab
mandarjog pushed a commit that referenced this pull request Nov 2, 2017
(Linters) Adding missing --update which should enhance the chance that
everyone sees the same/latest linter errors

Former-commit-id: 5752eab
rshriram pushed a commit to rshriram/istio that referenced this pull request Jul 31, 2018
* Add a Readme.md file for the MCP protocol.

* Add a link to the XDS protocol.
rshriram pushed a commit to rshriram/istio that referenced this pull request Jul 31, 2018
* Add a Readme.md file for the MCP protocol. (istio#565)

* Add a Readme.md file for the MCP protocol.

* Add a link to the XDS protocol.

* source_ip field is bool (istio#568)

* source_ip field is bool

- on the envoy side the source_ip field is
used as an indicator to determine whether or not
to use it as the hash value.

https://github.com/envoyproxy/envoy/blob/2c3c3e7546451a03cf4b7e9036ee48dda26fe49c/api/envoy/api/v2/route/route.proto#L535

* field now called use_source_ip

* Fix typos in comments. (istio#571)
howardjohn pushed a commit to howardjohn/istio that referenced this pull request Jan 12, 2020
* Add fields to values schema

* Make gen

* Add field descriptions

* Make gen
zmiklank pushed a commit to zmiklank/istio that referenced this pull request Jan 30, 2026
Add required config for TestEgressGatewayTls security test

Signed-off-by: Maxim Babushkin <mbabushk@redhat.com>
Co-authored-by: Maxim Babushkin <mbabushk@redhat.com>
dgn pushed a commit to dgn/istio that referenced this pull request Feb 17, 2026
* Fix TestEgressGatewayTls security test (istio#565)

Add required config for TestEgressGatewayTls security test

Signed-off-by: Maxim Babushkin <mbabushk@redhat.com>
Co-authored-by: Maxim Babushkin <mbabushk@redhat.com>

* Fix Telemetry tests Sail Operator config (istio#552) (istio#556)

Fix Telemetry integration tests configuration in Sail Operator setup
flow.

Signed-off-by: Maxim Babushkin <mbabushk@redhat.com>

* Fix security QUIC Sail Operator config (istio#568)

Add missing configuration for security QUIC based Istio integration
tests.

Signed-off-by: Maxim Babushkin <mbabushk@redhat.com>
Co-authored-by: Maxim Babushkin <mbabushk@redhat.com>

---------

Signed-off-by: Maxim Babushkin <mbabushk@redhat.com>
Co-authored-by: OpenShift Cherrypick Robot <openshift-cherrypick-robot@redhat.com>
Co-authored-by: Maxim Babushkin <mbabushk@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge Block automatic merging of a PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants