Skip to content

support read header value from env variable#55871

Merged
istio-testing merged 9 commits intoistio:masterfrom
zirain:read-header-value-from-env
Apr 20, 2025
Merged

support read header value from env variable#55871
istio-testing merged 9 commits intoistio:masterfrom
zirain:read-header-value-from-env

Conversation

@zirain
Copy link
Copy Markdown
Member

@zirain zirain commented Apr 10, 2025

Please provide a description of this PR:
api: istio/api#3474

fixes: #53408

@istio-testing
Copy link
Copy Markdown
Collaborator

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@istio-testing istio-testing added the do-not-merge/work-in-progress Block merging of a PR because it isn't ready yet. label Apr 10, 2025
@istio-testing istio-testing added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Apr 10, 2025
@zirain zirain changed the title support read from env support read header value from env variable Apr 10, 2025
@zirain
Copy link
Copy Markdown
Member Author

zirain commented Apr 10, 2025

/test all

@istio-testing istio-testing added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 10, 2025
@zirain
Copy link
Copy Markdown
Member Author

zirain commented Apr 10, 2025

/test all

2 similar comments
@zirain
Copy link
Copy Markdown
Member Author

zirain commented Apr 10, 2025

/test all

@zirain
Copy link
Copy Markdown
Member Author

zirain commented Apr 10, 2025

/test all

@zirain zirain force-pushed the read-header-value-from-env branch from 5d104d9 to e47b657 Compare April 10, 2025 13:40
@zirain
Copy link
Copy Markdown
Member Author

zirain commented Apr 10, 2025

/test all

2 similar comments
@zirain
Copy link
Copy Markdown
Member Author

zirain commented Apr 10, 2025

/test all

@zirain
Copy link
Copy Markdown
Member Author

zirain commented Apr 10, 2025

/test all

@zirain zirain force-pushed the read-header-value-from-env branch from cd02f5b to ae10cbd Compare April 16, 2025 00:08
@zirain zirain marked this pull request as ready for review April 16, 2025 00:11
@zirain zirain requested a review from a team April 16, 2025 00:11
@zirain zirain requested review from a team as code owners April 16, 2025 00:11
@zirain zirain requested a review from a team April 16, 2025 00:11
@zirain zirain requested review from a team as code owners April 16, 2025 00:11
@istio-testing istio-testing removed the do-not-merge/work-in-progress Block merging of a PR because it isn't ready yet. label Apr 16, 2025
Copy link
Copy Markdown
Member

@dhawton dhawton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will come back to this in a bit

@zirain zirain added the cherrypick/release-1.26 Set this label on a PR to auto-merge it to the release-1.26 branch label Apr 17, 2025
Copy link
Copy Markdown
Contributor

@keithmattix keithmattix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM outside of a testing nit

@zirain zirain requested review from dhawton and keithmattix April 19, 2025 01:09
@zirain
Copy link
Copy Markdown
Member Author

zirain commented Apr 19, 2025

/retest

@istio-testing
Copy link
Copy Markdown
Collaborator

@zirain: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
integ-ambient-mc_istio 198bba0 link false /test integ-ambient-mc
Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@istio-testing istio-testing merged commit a111e18 into istio:master Apr 20, 2025
29 of 30 checks passed
@istio-testing
Copy link
Copy Markdown
Collaborator

In response to a cherrypick label: new pull request created: #56018

@zirain zirain deleted the read-header-value-from-env branch April 20, 2025 10:40
fjglira pushed a commit to fjglira/istio that referenced this pull request Sep 26, 2025
* upstream/master:
  Automator: update proxy@master in istio/istio@master (istio#56019)
  support read header value from env variable (istio#55871)
  Automator: update proxy@master in istio/istio@master (istio#56017)
  Automator: update go-control-plane in istio/istio@master (istio#56016)
  Automator: update proxy@master in istio/istio@master (istio#56015)
  Automator: update ztunnel@master in istio/istio@master (istio#56012)
  Automator: update proxy@master in istio/istio@master (istio#56006)
  bump VERSION in master to 1.27 (istio#56000)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/environments area/extensions and telemetry cherrypick/release-1.26 Set this label on a PR to auto-merge it to the release-1.26 branch size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Otel configuration shows HTTP Authorization headers

6 participants