Merged
Conversation
howardjohn
reviewed
Apr 7, 2025
Member
howardjohn
left a comment
There was a problem hiding this comment.
This is only changing the override, not the base file as well. Once the base file and binary comes in, there will be a ton of lint errors from when I tried it?
a29cae8 to
2db9d3b
Compare
zirain
commented
Apr 8, 2025
zirain
commented
Apr 8, 2025
zirain
commented
Apr 8, 2025
zirain
commented
Apr 8, 2025
Member
Author
|
@howardjohn we're good to go? |
Member
Author
you're right, we can remove |
4813592 to
0176292
Compare
howardjohn
approved these changes
Apr 10, 2025
deveshdama
pushed a commit
to deveshdama/istio
that referenced
this pull request
Apr 18, 2025
fjglira
pushed a commit
to fjglira/istio
that referenced
this pull request
Sep 26, 2025
* upstream/master: Automator: update ztunnel@master in istio/istio@master (istio#55888) Automator: update proxy@master in istio/istio@master (istio#55882) golangci-lint v2 (istio#55828) Automator: update proxy@master in istio/istio@master (istio#55876) Automator: update common-files@master in istio/istio@master (istio#55878) addons: Bump addons version (istio#55874)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please provide a description of this PR:
wait istio/tools#3180 and istio/common-files#1167