remove unnecessary tls inspector#54080
Merged
istio-testing merged 2 commits intoistio:masterfrom Nov 27, 2024
Merged
Conversation
Signed-off-by: Rama Chavali <rama.rao@salesforce.com>
hzxuzhonghu
approved these changes
Nov 27, 2024
zirain
reviewed
Nov 27, 2024
| // match. We can do this for outbound as well, at which point this could be | ||
| // removed, but have not yet | ||
| if needTLSInspector || needHTTPInspector { | ||
| if needTLSInspector { |
Member
There was a problem hiding this comment.
do we need to check the proxy version?
Contributor
Author
There was a problem hiding this comment.
Not needed. The change was done in Envoy long time ago
MaYuan-02
pushed a commit
to MaYuan-02/istio
that referenced
this pull request
Dec 8, 2024
* remove unnecessary tls inspector Signed-off-by: Rama Chavali <rama.rao@salesforce.com> * rename Signed-off-by: Rama Chavali <rama.rao@salesforce.com> --------- Signed-off-by: Rama Chavali <rama.rao@salesforce.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The relevant envoy issue has been fixed envoyproxy/envoy#13601 - We do not have to add this automatically