Conversation
…fNotPresent/g' git ls-files|xargs sed -i .bak -e 's/PullPolicy: Always/PullPolicy: IfNotPresent/g' Fixes #441
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ldemailly Associated issue: 441 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
|
/retest |
| requests: | ||
| cpu: "100m" | ||
| imagePullPolicy: Always #IfNotPresent | ||
| imagePullPolicy: IfNotPresent #IfNotPresent |
There was a problem hiding this comment.
nit: we probably want to reverse the commented out bits here and below.
|
This is a dangerous PR. Please don't approve it automatically. If the tag is "0.2", it will cause inconsistent images used in pods (0.2.1 and 0.2.3). Please coordinate with Seb to make sure that only explicit tags are used, and for alias tags, change it back to Always. cc @rshriram |
|
And yes, we might need 2x YAML files, ones with Always and another ones with IfNotPresent. Just to make our lives better. |
|
@kyessenov You accepted and merged the exact same PR in pilot, how is this different? Also we have yet to make the first 0.2.0 and using 3 digits everywhere is something raised long ago What/where are the alias tags ? Why would we need Always ever or 2x yaml ? please elaborate |
…, but not supported by GetFromTreePath() (istio#532) * Fix GetFromTreePath issues when input path is longer than tree depth. * Refactor the tree traversal code. * Remove unreachable code. * Add complex tests, fix an issue of recursion on list node. * Add one more negtive test.
Signed-off-by: Yuanlin <yuanlin.xu@redhat.com>
git ls-files|xargs sed -i .bak -e 's/PullPolicy: Always/PullPolicy:
IfNotPresent/g'
Fixes #441
Should save a fair bit of network and overhead in tests and deployments