Conversation
|
/approve no-issue |
|
Totally understand your pain. Right now, we are all working on migrations, version update and since everything is failing after we move to 1.7, we are also trying to fix that. Will help you on this painful stuff as next week if we can make CI green on istio/istio. |
|
@kyessenov Did you use install/updateVersion.sh to generate files other than the template ? Just to make sure your change is not going to be removed next time someone run the script. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andraxylia, kyessenov, sebastienvas Associated issue requirement bypassed by: andraxylia The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
|
/release-note-none |
Former-commit-id: 6abc0f8
* add a config test * avoid segfaults in dns code * Update addresses to localhost * making the sandbox work * modify ingress ports * update goldens * buildifier * buildifier * add egress proxy too
Signed-off-by: Takeshi Yoneda <takeshi@tetrate.io>
* Set service subnet in kind provisioner * Skip upstream operator test suite * Run some StackDriver tests in a single-cluster setup only This is necessary because the fake GCP metadata server does not currently support multi-cluster setups.
@yutongz @sebastienvas we have to fix duplicates of installation files ASAP. This is a constant problem in pilot.