Conversation
|
Note this will require Bazel 0.5.2 or newer for building. DO NOT MERGE until test infra gets update. |
|
Jenkins job istio/presubmit passed |
ldemailly
left a comment
There was a problem hiding this comment.
thx, what's the PR for updating bazel in test infra?
|
I wonder why jenkins is happy and prow isn't |
|
Jenkins job istio/presubmit passed |
1 similar comment
|
Jenkins job istio/presubmit passed |
|
/retest |
|
@sebastienvas @yutongz When can this be merged? Prow seems failing every PR at the moment. |
|
/test all |
|
/approve |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ldemailly, lizan Assign the PR to them by writing Associated issue: 429 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these OWNERS Files:You can indicate your approval by writing |
|
@ldemailly The OWNERS file just got merged in. So now, if you would like to try "/approve" again, it should work :) |
|
We already using bazel 0.5.2. |
|
Jenkins job istio/presubmit passed |
1 similar comment
|
Jenkins job istio/presubmit passed |
|
This is also fails for me. The linter is broken. Jenkins does run the linters as no go files has been updated but prow does not have this optimization. |
sebastienvas
left a comment
There was a problem hiding this comment.
Please check linters on your marchine as well
|
@sebastienvas linters even fails on master, with same messages. |
|
I am not convinced. We submitted multiple PRs today without failures.
…On Aug 1, 2017 11:00 AM, "istio-bot" ***@***.***> wrote:
@lizan <https://github.com/lizan>: The following test *failed*, say
/retest to rerun them all:
Test name Commit Details Rerun command
prow/istio-presubmit.sh d93f0ad
<d93f0ad>
link
<https://k8s-gubernator.appspot.com/build/istio-prow/pull/istio_istio/508/istio-presubmit/158/> @istio-testing
bazel test this
Instructions for interacting with me using PR comments are available here
<https://github.com/kubernetes/community/blob/master/contributors/devel/pull-requests.md>.
If you have questions or suggestions related to my behavior, please file an
issue against the kubernetes/test-infra
<https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:>
repository. I understand the commands that are listed here
<https://github.com/kubernetes/test-infra/blob/master/commands.md>.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#508 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AQ80Z4EtDJONId_pWYlthun6kl8-wmkOks5sT2fYgaJpZM4OnIT9>
.
|
|
merged as it passed linters on prow/istio-presubmit.sh (not sure where Jenkins presubmit went) |
|
Jenkins presubmit is disabled because there are too many tests running on the e2e cluster. |
* Upgrade rules_go to 0.5.2 * Fix bazel_to_go.py to vendor go_repository Former-commit-id: 57d806c
* Upgrade rules_go to 0.5.2 * Fix bazel_to_go.py to vendor go_repository Former-commit-id: 57d806c
* Upgrade rules_go to 0.5.2 * Fix bazel_to_go.py to vendor go_repository Former-commit-id: 57d806c
* add missing istio-reader service account and binding * make gen
Co-authored-by: maistra-bot <null>
Update the path for Envoy proxy SHA
Added a function to check the stability of OpenShift cluster operators before running tests. Co-authored-by: Francisco Herrera <fjglira@gmail.com>
Added a function to check the stability of OpenShift cluster operators before running tests. Co-authored-by: Francisco Herrera <fjglira@gmail.com>
Added a function to check the stability of OpenShift cluster operators before running tests. Co-authored-by: Francisco Herrera <fjglira@gmail.com>
Fixes #429