Skip to content

WIP/Do Not Merge: a PR to fail presubmit#503

Closed
chxchx wants to merge 4 commits intoistio:masterfrom
chxchx:wrong
Closed

WIP/Do Not Merge: a PR to fail presubmit#503
chxchx wants to merge 4 commits intoistio:masterfrom
chxchx:wrong

Conversation

@chxchx
Copy link
Copy Markdown
Contributor

@chxchx chxchx commented Jul 27, 2017

No description provided.

@istio-testing
Copy link
Copy Markdown
Collaborator

@chxchx: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
prow/istio-presubmit.sh 80bdd9b link @istio-testing bazel test this
Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@istio-merge-robot
Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: chxchx
We suggest the following additional approvers:

Assign the PR to them by writing /assign in a comment when ready.

No associated issue. Update pull-request body to add a reference to an issue, or get approval with /approve no-issue

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@chxchx chxchx closed this Aug 1, 2017
mandarjog pushed a commit to mandarjog/istio that referenced this pull request Oct 30, 2017
* Update some shas.

- Get latest gogo build rules so we can finally get the latest gogo bits
with a bug fix I've been waiting for.

- Get latest grpc release which solves some spurious output I see on
shutdown during tests.

* Update our config protos to leverage gogo codegen options.


Former-commit-id: af2e1b3be54cdf3d32d4b5e7849ea01a8a9ae43d
mandarjog pushed a commit that referenced this pull request Oct 31, 2017
* Update some shas.

- Get latest gogo build rules so we can finally get the latest gogo bits
with a bug fix I've been waiting for.

- Get latest grpc release which solves some spurious output I see on
shutdown during tests.

* Update our config protos to leverage gogo codegen options.


Former-commit-id: 759a214ab7ec52b88cf9016078028b4793580a95
guptasu pushed a commit to guptasu/istio that referenced this pull request Jun 11, 2018
Merging release-0.8 to master
kyessenov pushed a commit to kyessenov/istio that referenced this pull request Aug 13, 2018
howardjohn pushed a commit to howardjohn/istio that referenced this pull request Jan 12, 2020
howardjohn pushed a commit to howardjohn/istio that referenced this pull request Jan 12, 2020
luksa pushed a commit to luksa/istio that referenced this pull request Apr 29, 2022
Co-authored-by: maistra-bot <null>
vikaschoudhary16 pushed a commit to vikaschoudhary16/istio that referenced this pull request Aug 12, 2024
Add back the `EnableK8SServiceSelectWorkloadEntries` flag
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants