Document how to add dependencies + linter fix + small improvement to setup_run#495
Merged
Document how to add dependencies + linter fix + small improvement to setup_run#495
Conversation
…setup_run Partial fix for #471
Collaborator
|
Jenkins job istio/presubmit passed |
sebastienvas
approved these changes
Jul 24, 2017
douglas-reid
approved these changes
Jul 24, 2017
ldemailly
added a commit
that referenced
this pull request
Jul 27, 2017
* fortio update - build and use fortio in perf/standalone scripts - fix for having more connections than requested * Updating sample to test using echosrv (slightly lower latency) Also changing threshold for sleep time histogram to 5% * Adding -gomaxprocs flag * One client per goroutine Now getting exactly the expected number of sockets But performance is still significantly lower than wrk * Adding profiler option * Homegrown http client On my Mac: Old net/http : 19.7k qps with 2 threads (-http -1) New -http 1 : 30.5k ops with 2 threads And 1/8th of the user cpu Interface to select between the 2 clients * More comments and backtrack test * http_test was missing from bazel ran gazelle * Added benchmark and fix folding bugs Folding is 4x faster than built in, 1/3rd of allocs Search is 10x faster, no alloc instead of a lot ``` BenchmarkASCIIFoldNormalToLower-8 3000000 416 ns/op 96 B/op 3 allocs/op BenchmarkASCIIFoldCustomToLowerMap-8 5000000 371 ns/op 96 B/op 3 allocs/op BenchmarkASCIIToUpper-8 20000000 104 ns/op 32 B/op 1 allocs/op BenchmarkFoldFind0-8 200000 7621 ns/op 2112 B/op 3 allocs/op BenchmarkFoldFind-8 2000000 669 ns/op 0 B/op 0 allocs/op ``` * chunked decoding unit test for parsing, reads the first chunk * fasthttp client wrapper (-http 3) - added some doc in WORKSPACE about wtool - initial support for fasthttp * Make linter happy though I might drop fasthttp as it’s not faster (but it’s more complete) and adds a lot of dependencies * Split connect out * Fixing merge error * adding fortio Logger * Fixing bazel build And misc comment/leftover from #460 etc * Shorter logger names * Switched to new logging * Eradicate Verbosity leftovers * Added -logprefix and -logcaller; Refactor start on http.go also fixed a couple of calls missing % codes * Minor edits, saving to GitHub wip * Woot http1.1 works now Still unwieldy but working ! * Some profiler optimizations * More profiler opt * Make lint happy by making checking connection closed header a flag * Dropping fasthttp dependency * Moved 3 changes to #495 * Minor: use version in echoers, use 3 digits * Code review updates (thx doug!) + serious chunked bug fix Wasn’t working with last chunk (0\r\n\r\n) being in a separate frame * Code review comment thx doug!
rshriram
pushed a commit
that referenced
this pull request
Oct 30, 2017
* fortio update - build and use fortio in perf/standalone scripts - fix for having more connections than requested * Updating sample to test using echosrv (slightly lower latency) Also changing threshold for sleep time histogram to 5% * Adding -gomaxprocs flag * One client per goroutine Now getting exactly the expected number of sockets But performance is still significantly lower than wrk * Adding profiler option * Homegrown http client On my Mac: Old net/http : 19.7k qps with 2 threads (-http -1) New -http 1 : 30.5k ops with 2 threads And 1/8th of the user cpu Interface to select between the 2 clients * More comments and backtrack test * http_test was missing from bazel ran gazelle * Added benchmark and fix folding bugs Folding is 4x faster than built in, 1/3rd of allocs Search is 10x faster, no alloc instead of a lot ``` BenchmarkASCIIFoldNormalToLower-8 3000000 416 ns/op 96 B/op 3 allocs/op BenchmarkASCIIFoldCustomToLowerMap-8 5000000 371 ns/op 96 B/op 3 allocs/op BenchmarkASCIIToUpper-8 20000000 104 ns/op 32 B/op 1 allocs/op BenchmarkFoldFind0-8 200000 7621 ns/op 2112 B/op 3 allocs/op BenchmarkFoldFind-8 2000000 669 ns/op 0 B/op 0 allocs/op ``` * chunked decoding unit test for parsing, reads the first chunk * fasthttp client wrapper (-http 3) - added some doc in WORKSPACE about wtool - initial support for fasthttp * Make linter happy though I might drop fasthttp as it’s not faster (but it’s more complete) and adds a lot of dependencies * Split connect out * Fixing merge error * adding fortio Logger * Fixing bazel build And misc comment/leftover from #460 etc * Shorter logger names * Switched to new logging * Eradicate Verbosity leftovers * Added -logprefix and -logcaller; Refactor start on http.go also fixed a couple of calls missing % codes * Minor edits, saving to GitHub wip * Woot http1.1 works now Still unwieldy but working ! * Some profiler optimizations * More profiler opt * Make lint happy by making checking connection closed header a flag * Dropping fasthttp dependency * Moved 3 changes to #495 * Minor: use version in echoers, use 3 digits * Code review updates (thx doug!) + serious chunked bug fix Wasn’t working with last chunk (0\r\n\r\n) being in a separate frame * Code review comment thx doug! Former-commit-id: e09dcaf
vbatts
pushed a commit
to vbatts/istio
that referenced
this pull request
Oct 31, 2017
* fortio update - build and use fortio in perf/standalone scripts - fix for having more connections than requested * Updating sample to test using echosrv (slightly lower latency) Also changing threshold for sleep time histogram to 5% * Adding -gomaxprocs flag * One client per goroutine Now getting exactly the expected number of sockets But performance is still significantly lower than wrk * Adding profiler option * Homegrown http client On my Mac: Old net/http : 19.7k qps with 2 threads (-http -1) New -http 1 : 30.5k ops with 2 threads And 1/8th of the user cpu Interface to select between the 2 clients * More comments and backtrack test * http_test was missing from bazel ran gazelle * Added benchmark and fix folding bugs Folding is 4x faster than built in, 1/3rd of allocs Search is 10x faster, no alloc instead of a lot ``` BenchmarkASCIIFoldNormalToLower-8 3000000 416 ns/op 96 B/op 3 allocs/op BenchmarkASCIIFoldCustomToLowerMap-8 5000000 371 ns/op 96 B/op 3 allocs/op BenchmarkASCIIToUpper-8 20000000 104 ns/op 32 B/op 1 allocs/op BenchmarkFoldFind0-8 200000 7621 ns/op 2112 B/op 3 allocs/op BenchmarkFoldFind-8 2000000 669 ns/op 0 B/op 0 allocs/op ``` * chunked decoding unit test for parsing, reads the first chunk * fasthttp client wrapper (-http 3) - added some doc in WORKSPACE about wtool - initial support for fasthttp * Make linter happy though I might drop fasthttp as it’s not faster (but it’s more complete) and adds a lot of dependencies * Split connect out * Fixing merge error * adding fortio Logger * Fixing bazel build And misc comment/leftover from istio#460 etc * Shorter logger names * Switched to new logging * Eradicate Verbosity leftovers * Added -logprefix and -logcaller; Refactor start on http.go also fixed a couple of calls missing % codes * Minor edits, saving to GitHub wip * Woot http1.1 works now Still unwieldy but working ! * Some profiler optimizations * More profiler opt * Make lint happy by making checking connection closed header a flag * Dropping fasthttp dependency * Moved 3 changes to istio#495 * Minor: use version in echoers, use 3 digits * Code review updates (thx doug!) + serious chunked bug fix Wasn’t working with last chunk (0\r\n\r\n) being in a separate frame * Code review comment thx doug! Former-commit-id: e09dcaf
mandarjog
pushed a commit
that referenced
this pull request
Oct 31, 2017
* Let discovery list all services from /v1/registration/ * Test data should be sorted because Golang map iteration is not stable but diff.go expects stable serialization * Incorporate Jason's code simplification requests * Return array of key-and-service * List all Clusters and all Routes * Incorporate refactoring * Incorporate Jason's suggestions
mandarjog
pushed a commit
that referenced
this pull request
Nov 2, 2017
* fortio update - build and use fortio in perf/standalone scripts - fix for having more connections than requested * Updating sample to test using echosrv (slightly lower latency) Also changing threshold for sleep time histogram to 5% * Adding -gomaxprocs flag * One client per goroutine Now getting exactly the expected number of sockets But performance is still significantly lower than wrk * Adding profiler option * Homegrown http client On my Mac: Old net/http : 19.7k qps with 2 threads (-http -1) New -http 1 : 30.5k ops with 2 threads And 1/8th of the user cpu Interface to select between the 2 clients * More comments and backtrack test * http_test was missing from bazel ran gazelle * Added benchmark and fix folding bugs Folding is 4x faster than built in, 1/3rd of allocs Search is 10x faster, no alloc instead of a lot ``` BenchmarkASCIIFoldNormalToLower-8 3000000 416 ns/op 96 B/op 3 allocs/op BenchmarkASCIIFoldCustomToLowerMap-8 5000000 371 ns/op 96 B/op 3 allocs/op BenchmarkASCIIToUpper-8 20000000 104 ns/op 32 B/op 1 allocs/op BenchmarkFoldFind0-8 200000 7621 ns/op 2112 B/op 3 allocs/op BenchmarkFoldFind-8 2000000 669 ns/op 0 B/op 0 allocs/op ``` * chunked decoding unit test for parsing, reads the first chunk * fasthttp client wrapper (-http 3) - added some doc in WORKSPACE about wtool - initial support for fasthttp * Make linter happy though I might drop fasthttp as it’s not faster (but it’s more complete) and adds a lot of dependencies * Split connect out * Fixing merge error * adding fortio Logger * Fixing bazel build And misc comment/leftover from #460 etc * Shorter logger names * Switched to new logging * Eradicate Verbosity leftovers * Added -logprefix and -logcaller; Refactor start on http.go also fixed a couple of calls missing % codes * Minor edits, saving to GitHub wip * Woot http1.1 works now Still unwieldy but working ! * Some profiler optimizations * More profiler opt * Make lint happy by making checking connection closed header a flag * Dropping fasthttp dependency * Moved 3 changes to #495 * Minor: use version in echoers, use 3 digits * Code review updates (thx doug!) + serious chunked bug fix Wasn’t working with last chunk (0\r\n\r\n) being in a separate frame * Code review comment thx doug! Former-commit-id: e09dcaf
guptasu
pushed a commit
to guptasu/istio
that referenced
this pull request
Jun 11, 2018
Also fix one more Python-related build warning.
kyessenov
pushed a commit
to kyessenov/istio
that referenced
this pull request
Aug 13, 2018
danehans
pushed a commit
to danehans/istio
that referenced
this pull request
Nov 2, 2021
fjglira
pushed a commit
to fjglira/istio
that referenced
this pull request
Sep 26, 2025
…ter-merge_upstream_istio_master-6253864e Automator: merge upstream changes to openshift-service-mesh/istio@master
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partial fix for #471