Copy start_envoy and envoy.conf.template into istio/istio from proxy by yutongz · Pull Request #4358 · istio/istio

yutongz · 2018-03-19T08:19:03Z

codecov · 2018-03-19T19:53:42Z

Codecov Report

Merging #4358 into master will decrease coverage by 1%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #4358    +/-   ##
=======================================
- Coverage      71%     71%   -<1%     
=======================================
  Files         325     325            
  Lines       29651   29565    -86     
=======================================
- Hits        20812   20711   -101     
- Misses       7594    7607    +13     
- Partials     1245    1247     +2

Impacted Files	Coverage Δ
...olarwinds/internal/papertrail/papertrail_logger.go	`59% <0%> (-21%)`	⬇️
mixer/adapter/solarwinds/log_handler.go	`58% <0%> (-15%)`	⬇️
...er/adapter/solarwinds/internal/appoptics/client.go	`57% <0%> (-12%)`	⬇️
pilot/pkg/config/memory/monitor.go	`82% <0%> (-9%)`	⬇️
pilot/pkg/serviceregistry/kube/queue.go	`86% <0%> (-3%)`	⬇️
mixer/adapter/denier/denier.go	`93% <0%> (-3%)`	⬇️
mixer/adapter/rbac/rbacStore.go	`83% <0%> (-1%)`	⬇️
mixer/adapter/servicecontrol/reportbuilder.go	`89% <0%> (ø)`	⬇️
mixer/adapter/servicecontrol/utils.go	`89% <0%> (ø)`	⬇️
mixer/template/sample/template.gen.go	`55% <0%> (ø)`	⬇️
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 615959e...7874862. Read the comment docs.

yutongz · 2018-03-19T20:01:23Z

/cc @andraxylia @qiwzhang

ldemailly · 2018-03-20T01:02:22Z

can you just put a header on both this file and the original one to reference each other
so someone knows to update both ?
(tricky part: what is a json comment?)

/lgtm
/hold

kyessenov · 2018-03-20T01:11:51Z

/lgtm

…

On Mon, Mar 19, 2018 at 6:02 PM Laurent Demailly ***@***.***> wrote: can you just put a header on both this file and the original one to reference each other so someone knows to update both ? (tricky part: what is a json comment?) — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#4358 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AJGIxjVBHK2_xLMIFdxtOFPUUe4hlvLcks5tgFUmgaJpZM4Svvwq> .

istio-merge-robot · 2018-03-20T01:12:37Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kyessenov, ldemailly

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these OWNERS Files:

~~tests/OWNERS~~ [kyessenov,ldemailly]

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

istio-merge-robot · 2018-03-20T01:12:50Z

/test all [submit-queue is verifying that this PR is safe to merge]

ldemailly · 2018-03-20T03:31:20Z

looks like you got the broken version:

[2018-03-20 01:16:33.796][11235][debug][main] external/envoy/source/server/server.cc:164] Unable to initialize config as v2, will retry as v1: Unable to parse JSON as proto (INVALID_ARGUMENT:cluster_manager: Cannot find field.):

ldemailly

ty

ldemailly · 2018-03-22T22:17:26Z

/lgtm

istio-testing · 2018-03-22T22:17:29Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kyessenov, ldemailly

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [ldemailly]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Automatic merge from submit-queue. Add notification for duplication **What this PR does / why we need it**: **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes # **Special notes for your reviewer**: **Release note**: ```release-note ``` Add notification to match istio/istio#4358

yutongz · 2018-03-23T08:53:06Z

/hold cancel
Reviewer approved, all required tests passed.

istio-merge-robot · 2018-03-23T08:58:12Z

/test all [submit-queue is verifying that this PR is safe to merge]

istio-testing · 2018-03-23T09:30:45Z

@yutongz: The following tests failed, say /retest to rerun them all:

Test name	Commit	Details	Rerun command
prow/istio-pilot-e2e-v1alpha3.sh	`7874862`	link	`/test istio-pilot-e2e-v1alpha3`
prow/istio-pilot-e2e.sh	`7874862`	link	`/test istio-pilot-e2e`

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

istio-merge-robot · 2018-03-23T09:40:16Z

Automatic merge from submit-queue.

googlebot added the cla: yes label Mar 19, 2018

Copy start_envoy and envoy.conf.template into istio/istio from proxy

053c137

yutongz force-pushed the integration_f branch from d6c7a68 to 053c137 Compare March 19, 2018 19:20

istio-testing requested review from andraxylia and qiwzhang March 19, 2018 20:01

ldemailly approved these changes Mar 20, 2018

View reviewed changes

istio-merge-robot added the approved label Mar 20, 2018

istio-testing assigned kyessenov Mar 20, 2018

istio-testing added the lgtm label Mar 20, 2018

ldemailly added do-not-merge Block automatic merging of a PR. do-not-merge/hold Block automatic merging of a PR. labels Mar 20, 2018

Add readme about proxy config, clean generated local tmp files

7874862

istio-testing removed the lgtm label Mar 22, 2018

yutongz mentioned this pull request Mar 22, 2018

Add notification for duplication istio/proxy#1234

Merged

ldemailly approved these changes Mar 22, 2018

View reviewed changes

istio-testing assigned ldemailly Mar 22, 2018

istio-testing added the lgtm label Mar 22, 2018

istio-testing removed the do-not-merge/hold Block automatic merging of a PR. label Mar 23, 2018

yutongz removed the do-not-merge Block automatic merging of a PR. label Mar 23, 2018

istio-merge-robot merged commit 8f97c88 into istio:master Mar 23, 2018

Conversation

yutongz commented Mar 19, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov bot commented Mar 19, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

yutongz commented Mar 19, 2018

Uh oh!

ldemailly commented Mar 20, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kyessenov commented Mar 20, 2018 via email

Uh oh!

istio-merge-robot commented Mar 20, 2018

Uh oh!

istio-merge-robot commented Mar 20, 2018

Uh oh!

ldemailly commented Mar 20, 2018

Uh oh!

ldemailly left a comment

Choose a reason for hiding this comment

Uh oh!

ldemailly commented Mar 22, 2018

Uh oh!

istio-testing commented Mar 22, 2018

Uh oh!

yutongz commented Mar 23, 2018

Uh oh!

istio-merge-robot commented Mar 23, 2018

Uh oh!

istio-testing commented Mar 23, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

istio-merge-robot commented Mar 23, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

yutongz commented Mar 19, 2018 •

edited

Loading

codecov bot commented Mar 19, 2018 •

edited

Loading

ldemailly commented Mar 20, 2018 •

edited

Loading

istio-testing commented Mar 23, 2018 •

edited

Loading