Change memory config map to sync.Map#4137
Merged
xiaolanz merged 2 commits intoistio:masterfrom Mar 10, 2018
Merged
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ayj The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
Codecov Report
@@ Coverage Diff @@
## master #4137 +/- ##
=======================================
- Coverage 73% 73% -<1%
=======================================
Files 313 313
Lines 28829 28730 -99
=======================================
- Hits 20936 20847 -89
+ Misses 6570 6558 -12
- Partials 1323 1325 +2
Continue to review full report at Codecov.
|
Contributor
Author
|
/retest |
sebastienvas
added a commit
that referenced
this pull request
Mar 10, 2018
This reverts commit 7b089fa.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
address race condition to access the map. #4041