Enable cluster provisioning on all e2e by sebastienvas · Pull Request #3790 · istio/istio

sebastienvas · 2018-02-26T23:27:04Z

No description provided.

codecov · 2018-02-26T23:45:17Z

Codecov Report

Merging #3790 into master will decrease coverage by 1%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #3790    +/-   ##
=======================================
- Coverage      77%     76%   -<1%     
=======================================
  Files         291     291            
  Lines       26847   26912    +65     
=======================================
+ Hits        20423   20433    +10     
- Misses       5120    5171    +51     
- Partials     1304    1308     +4

Impacted Files	Coverage Δ
...olarwinds/internal/papertrail/papertrail_logger.go	`59% <0%> (-21%)`	⬇️
mixer/adapter/list/regexList.go	`69% <0%> (-9%)`	⬇️
pilot/pkg/config/memory/monitor.go	`82% <0%> (-9%)`	⬇️
mixer/adapter/prometheus/server.go	`95% <0%> (-5%)`	⬇️
pilot/pkg/serviceregistry/kube/controller.go	`64% <0%> (-4%)`	⬇️
mixer/pkg/config/storetest/storetest.go	`57% <0%> (-4%)`	⬇️
pilot/pkg/serviceregistry/kube/queue.go	`86% <0%> (-3%)`	⬇️
mixer/adapter/circonus/circonus.go	`69% <0%> (-2%)`	⬇️
mixer/adapter/servicecontrol/checkprocessor.go	`80% <0%> (-2%)`	⬇️
pilot/pkg/proxy/envoy/v2/mesh.go	`75% <0%> (ø)`	⬇️
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1bef28b...46130c9. Read the comment docs.

sebastienvas · 2018-02-27T05:55:56Z

/test e2e-bookInfo

sebastienvas · 2018-02-27T05:56:07Z

/test e2e-simple

chxchx · 2018-02-27T06:06:32Z

/lgtm

istio-merge-robot · 2018-02-27T06:07:56Z

/test all [submit-queue is verifying that this PR is safe to merge]

chxchx · 2018-02-27T06:09:37Z

/hold

bookinfo and simple tests are not required at the moment but I want to see them passing before the merge bot acting too fast. Anyone please comment hold cancel once they pass

sebastienvas · 2018-02-27T06:26:51Z

it should work however I discovered that when we do the test command for a given target, since we have 2 entries in the prow config, it triggers both and since we have the same name, the second starting abort the first one which is why it failed when I manually try to start it. I ll check with the k8s guys if they ever encountered this.

istio-merge-robot · 2018-02-27T06:47:53Z

/lgtm cancel //PR changed after LGTM, removing LGTM. @chxchx @sebastienvas

rkpagadala · 2018-02-27T17:53:58Z


-source ${ROOT}/prow/lib.sh
+# Check https://github.com/istio/test-infra/blob/master/boskos/configs.yaml
+# for exiting resources types


rkpagadala · 2018-02-27T17:54:19Z

-
-export NUM_NODES=4
+# Check https://github.com/istio/test-infra/blob/master/boskos/configs.yaml
+# for exiting resources types


typo: existing

rkpagadala · 2018-02-27T17:55:36Z

-source ${ROOT}/prow/lib.sh
-setup_and_export_git_sha
-
-export NUM_NODES=4


Is this not needed? How do we get 4 nodes for this test?

the pool already created cluster with 4 nodes. https://github.com/sebastienvas/test-infra/blob/eba53851a4e94bda1abb2b1e50e5ba0457a750d7/boskos/configs.yaml#L12

rkpagadala · 2018-02-27T17:57:24Z

-setup_and_export_git_sha
-
-export NUM_NODES=4
+# Check https://github.com/istio/test-infra/blob/master/boskos/configs.yaml


the url is wrong

rkpagadala · 2018-02-27T17:57:46Z

-E2E_ARGS=()

-source ${ROOT}/prow/lib.sh
+# Check https://github.com/istio/test-infra/blob/master/boskos/configs.yaml


url is wrong

PR is pending. istio/test-infra#690

yutongz

/lgtm

istio-merge-robot · 2018-02-27T18:15:27Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chxchx, yutongz

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these OWNERS Files:

~~prow/OWNERS~~ [chxchx,yutongz]

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

sebastienvas

PTAL

sebastienvas · 2018-02-27T18:20:02Z

-E2E_ARGS=()

-source ${ROOT}/prow/lib.sh
+# Check https://github.com/istio/test-infra/blob/master/boskos/configs.yaml


PR is pending. istio/test-infra#690

sebastienvas · 2018-02-27T18:21:49Z


-source ${ROOT}/prow/lib.sh
+# Check https://github.com/istio/test-infra/blob/master/boskos/configs.yaml
+# for exiting resources types


sebastienvas · 2018-02-27T18:22:02Z

-setup_and_export_git_sha
-
-export NUM_NODES=4
+# Check https://github.com/istio/test-infra/blob/master/boskos/configs.yaml


sebastienvas · 2018-02-27T18:22:04Z

-
-export NUM_NODES=4
+# Check https://github.com/istio/test-infra/blob/master/boskos/configs.yaml
+# for exiting resources types


sebastienvas · 2018-02-27T18:23:19Z

-source ${ROOT}/prow/lib.sh
-setup_and_export_git_sha
-
-export NUM_NODES=4


the pool already created cluster with 4 nodes. https://github.com/sebastienvas/test-infra/blob/eba53851a4e94bda1abb2b1e50e5ba0457a750d7/boskos/configs.yaml#L12

Remote gateways defer to the network ID if there is no cluster ID. If there is no cluster ID, warn the user and disable draining.

Enable cluster provisioning on all e2e

6cd1bcb

sebastienvas requested a review from a team February 26, 2018 23:27

googlebot added the cla: yes label Feb 26, 2018

sebastienvas requested a review from rkpagadala February 26, 2018 23:27

sebastienvas added 2 commits February 26, 2018 15:47

Enable mason for istio-pilot-e2e

3b5c9ef

Fixed typo

4d6de91

sebastienvas mentioned this pull request Feb 27, 2018

Enabling mason for master and next releases istio/test-infra#707

Merged

sebastienvas requested a review from ldemailly February 27, 2018 05:56

istio-testing assigned chxchx Feb 27, 2018

istio-testing added the lgtm label Feb 27, 2018

istio-merge-robot added the approved label Feb 27, 2018

istio-testing added the do-not-merge/hold Block automatic merging of a PR. label Feb 27, 2018

Set TEST_TARGETS as an array

779b733

istio-merge-robot removed the lgtm label Feb 27, 2018

rkpagadala reviewed Feb 27, 2018

View reviewed changes

yutongz approved these changes Feb 27, 2018

View reviewed changes

Fix typo

46130c9

sebastienvas commented Feb 27, 2018

View reviewed changes

sebastienvas merged commit 3db4261 into istio:master Feb 27, 2018

sebastienvas deleted the e2e-boskos branch February 27, 2018 18:59

PetrMc pushed a commit that referenced this pull request Apr 10, 2026

Draining needs the cluster ID (#3790)

412e856

Remote gateways defer to the network ID if there is no cluster ID. If there is no cluster ID, warn the user and disable draining.

Conversation

sebastienvas commented Feb 26, 2018

Uh oh!

codecov Bot commented Feb 26, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

sebastienvas commented Feb 27, 2018

Uh oh!

sebastienvas commented Feb 27, 2018

Uh oh!

chxchx commented Feb 27, 2018

Uh oh!

istio-merge-robot commented Feb 27, 2018

Uh oh!

chxchx commented Feb 27, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sebastienvas commented Feb 27, 2018

Uh oh!

istio-merge-robot commented Feb 27, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

yutongz left a comment

Choose a reason for hiding this comment

Uh oh!

istio-merge-robot commented Feb 27, 2018

Uh oh!

sebastienvas left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

codecov Bot commented Feb 26, 2018 •

edited

Loading

chxchx commented Feb 27, 2018 •

edited

Loading