Skip to content

Always use separate check and report clusters for mixer#3671

Merged
mandarjog merged 2 commits intoistio:masterfrom
mandarjog:mixer_check_report
Feb 22, 2018
Merged

Always use separate check and report clusters for mixer#3671
mandarjog merged 2 commits intoistio:masterfrom
mandarjog:mixer_check_report

Conversation

@mandarjog
Copy link
Copy Markdown
Contributor

  1. This ensures that separate stats are collected even if same cluster is used.
  2. For prod use it will be multiple clusters.

@mandarjog mandarjog requested a review from a team February 21, 2018 23:39
@istio-merge-robot
Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
We suggest the following additional approver: ldemailly

Assign the PR to them by writing /assign @ldemailly in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@mandarjog
Copy link
Copy Markdown
Contributor Author

/test istio-pilot-e2e

@costinm
Copy link
Copy Markdown
Contributor

costinm commented Feb 22, 2018

/lgtm

@mandarjog mandarjog merged commit 97770de into istio:master Feb 22, 2018
PetrMc added a commit to PetrMc/istio-petrmc-upstream-fork that referenced this pull request Jan 14, 2026
* add ingress-use-waypoint label handling

Signed-off-by: Petr McAllister <petr.mcallister@gmail.com>

* merge leftovers

Signed-off-by: Petr McAllister <petr.mcallister@gmail.com>

* address review comments

Signed-off-by: Petr McAllister <petr.mcallister@gmail.com>

* respect local cluster label

Signed-off-by: Petr McAllister <petr.mcallister@gmail.com>

---------

Signed-off-by: Petr McAllister <petr.mcallister@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants