Skip to content

remove unnecessary deployment-level sidecar.istio.io/inject annotation#3664

Merged
ayj merged 2 commits intoistio:masterfrom
ayj:fix-sidecar-annotation
Mar 6, 2018
Merged

remove unnecessary deployment-level sidecar.istio.io/inject annotation#3664
ayj merged 2 commits intoistio:masterfrom
ayj:fix-sidecar-annotation

Conversation

@ayj
Copy link
Copy Markdown
Contributor

@ayj ayj commented Feb 21, 2018

No description provided.

@ayj ayj requested a review from a team February 21, 2018 20:39
@istio-merge-robot
Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
We suggest the following additional approver: kyessenov

Assign the PR to them by writing /assign @kyessenov in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@ayj
Copy link
Copy Markdown
Contributor Author

ayj commented Feb 22, 2018

/retest

@ayj ayj requested a review from costinm February 27, 2018 01:26
Copy link
Copy Markdown
Contributor

@costinm costinm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why ? Confused...

@ayj
Copy link
Copy Markdown
Contributor Author

ayj commented Mar 1, 2018

Why ? Confused...

The annotation is used for automatic injection. The injection webhook is registered for pods and the deployment-level annotation isn't visible to the webhook. Only information specified in the PodTemplateSpec is used by the webhook.

@ayj
Copy link
Copy Markdown
Contributor Author

ayj commented Mar 1, 2018

/retest

Copy link
Copy Markdown
Contributor

@costinm costinm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-injector will auto-exclude the namespace ?

@ayj
Copy link
Copy Markdown
Contributor Author

ayj commented Mar 6, 2018

Namespace scoping is handled via NamespaceSelector in webhook registration. We don't register the webhook for namespaces that aren't subject to injection.

@ayj ayj merged commit 09c368f into istio:master Mar 6, 2018
@ayj ayj deleted the fix-sidecar-annotation branch March 6, 2018 18:21
PetrMc pushed a commit to PetrMc/istio-petrmc-upstream-fork that referenced this pull request Jan 14, 2026
…3664)

* peering: istioctl check for stale WE and bad environment vars

* relnote

* gen/lint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants