Skip to content

Support unix:// paths for pilot xDS webhook#3654

Merged
istio-merge-robot merged 1 commit intoistio:masterfrom
spikecurtis:unix-websocket
Feb 21, 2018
Merged

Support unix:// paths for pilot xDS webhook#3654
istio-merge-robot merged 1 commit intoistio:masterfrom
spikecurtis:unix-websocket

Conversation

@spikecurtis
Copy link
Copy Markdown
Member

Signed-off-by: Spike Curtis spike@tigera.io

Signed-off-by: Spike Curtis <spike@tigera.io>
Copy link
Copy Markdown
Contributor

@kyessenov kyessenov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@istio-merge-robot
Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kyessenov

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@istio-merge-robot
Copy link
Copy Markdown

/test all [submit-queue is verifying that this PR is safe to merge]

@istio-merge-robot
Copy link
Copy Markdown

Automatic merge from submit-queue.

@istio-merge-robot istio-merge-robot merged commit f32f75d into istio:master Feb 21, 2018
@istio-testing
Copy link
Copy Markdown
Collaborator

@spikecurtis: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
prow/istio-pilot-e2e.sh 8099f7f link /test istio-pilot-e2e
Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

PetrMc pushed a commit to PetrMc/istio-petrmc-upstream-fork that referenced this pull request Jan 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants