Skip to content

Remove unguarded log.Info from request path#3642

Merged
istio-merge-robot merged 2 commits intoistio:masterfrom
mandarjog:remove_logging
Feb 21, 2018
Merged

Remove unguarded log.Info from request path#3642
istio-merge-robot merged 2 commits intoistio:masterfrom
mandarjog:remove_logging

Conversation

@mandarjog
Copy link
Copy Markdown
Contributor

@mandarjog mandarjog commented Feb 21, 2018

Remove log.Info from request path.
It causes excessive usage of zap.log and lock contention.

@mandarjog mandarjog requested review from a team, ldemailly and ozevren February 21, 2018 08:32
@mandarjog mandarjog changed the title Remove unguarded log.Info from request.path Remove unguarded log.Info from request path Feb 21, 2018
@mandarjog mandarjog self-assigned this Feb 21, 2018
ldemailly
ldemailly approved these changes Feb 21, 2018
View reviewed changes
Copy link
Copy Markdown
Member

@ldemailly ldemailly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's the only one ?
should it be a log.Debug instead ?

@ldemailly
Copy link
Copy Markdown
Member

ldemailly commented Feb 21, 2018

/lgtm
/retest

@istio-merge-robot
Copy link
Copy Markdown

istio-merge-robot commented Feb 21, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ldemailly

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@istio-merge-robot
Copy link
Copy Markdown

istio-merge-robot commented Feb 21, 2018

/test all [submit-queue is verifying that this PR is safe to merge]

@istio-merge-robot
Copy link
Copy Markdown

istio-merge-robot commented Feb 21, 2018

Automatic merge from submit-queue.

@istio-merge-robot istio-merge-robot merged commit 65dd56a into istio:master Feb 21, 2018
@istio-testing
Copy link
Copy Markdown
Collaborator

istio-testing commented Feb 21, 2018

@mandarjog: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
prow/istio-pilot-e2e.sh a3cfcd7 link /test istio-pilot-e2e
Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

PetrMc pushed a commit to PetrMc/istio-petrmc-upstream-fork that referenced this pull request Jan 14, 2026
@soloio-bot
Bump Istio dependencies for master-solo branch (istio#3642)
cc39fcf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ozevren ozevren Awaiting requested review from ozevren

1 more reviewer

@ldemailly ldemailly ldemailly approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@mandarjog mandarjog

@ldemailly ldemailly

Labels

area/perf and scalability

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@mandarjog @ldemailly @istio-merge-robot @istio-testing @googlebot