Manager -> pilot rename by ldemailly · Pull Request #359 · istio/istio

ldemailly · 2017-06-05T23:44:03Z

skipping bookinfo and tests/e2e(*) which have other managers

*: checking the rest of e2e by hand now

git ls-files | grep -v tests/e2e|grep -v bookinfo| xargs -n 1 sed -i .bak -e 's/Manager/Pilot/g' As tests/e2e and bookinfo have other Manager unrelated to pilot

git ls-files | grep -v tests/e2e|grep -v bookinfo| xargs -n 1 sed -i .bak -e 's/manager/pilot/g'

kyessenov · 2017-06-05T23:46:33Z

install/kubernetes/templates/istio-manager.yaml

@@ -1,4 +1,4 @@
-# Manager service for discovery
+# Pilot service for discovery


rename the file itself

git ls-files | xargs -n 1 sed -i .bak -e 's/MANAGER/PILOT/g' and manually excluding some

Last piece, only remaining ‘manager’ are: ``` ldemailly-macbookpro:istio ldemailly$ git grep -i manager samples/apps/bookinfo/src/reviews/reviews-wlpcfg/servers/LibertyProjectS erver/server.xml: <featureManager> samples/apps/bookinfo/src/reviews/reviews-wlpcfg/servers/LibertyProjectS erver/server.xml: </featureManager> tests/e2e/README.md:### appManager.go tests/e2e/README.md:`appManager` gather apps required for test into a array and deploy them while setup() tests/e2e/framework/BUILD: "appManager.go", tests/e2e/framework/appManager.go:// AppManager organize and deploy apps tests/e2e/framework/appManager.go:type AppManager struct { tests/e2e/framework/appManager.go:// NewAppManager create a new AppManager tests/e2e/framework/appManager.go:func NewAppManager(tmpDir, namespace string, istioctl *Istioctl) *AppManager { tests/e2e/framework/appManager.go: return &AppManager{ tests/e2e/framework/appManager.go:func (am *AppManager) generateAppYaml(a *App) error { tests/e2e/framework/appManager.go:func (am *AppManager) deploy(a *App) error { tests/e2e/framework/appManager.go:func (am *AppManager) Setup() error { tests/e2e/framework/appManager.go:func (am *AppManager) Teardown() error { tests/e2e/framework/appManager.go:func (am *AppManager) AddApp(a *App) { tests/e2e/framework/framework.go: c.Cleanup.RegisterCleanable(c.Kube.AppManager) tests/e2e/framework/kubernetes.go: pilotHub = flag.String("pilot_hub", os.Getenv(pilotHubEnvVar), "Manager hub") tests/e2e/framework/kubernetes.go: pilotTag = flag.String("pilot_tag", os.Getenv(pilotTagEnvVar), "Manager tag") tests/e2e/framework/kubernetes.go: "manager", tests/e2e/framework/kubernetes.go: // App Manager tests/e2e/framework/kubernetes.go: AppManager *AppManager tests/e2e/framework/kubernetes.go: a := NewAppManager(tmpDir, *namespace, i) tests/e2e/framework/kubernetes.go: AppManager: a, tests/e2e/framework/kubernetes.go: case "manager": tests/e2e/tests/bookinfo/demo_test.go: tc.Kube.AppManager.AddApp(demoApp) tests/e2e/tests/mixer/mixer_test.go: tc.Kube.AppManager.AddApp(demoApp) ```

kyessenov

The only way to know if it works, is to run it.

sebastienvas · 2017-06-06T01:03:00Z

install/updateVersion.sh

  case ${arg} in
    i) ISTIOCTL_URL="${OPTARG}";;
-    m) MANAGER_HUB_TAG="${OPTARG}";; # Format: "<hub>,<tag>"
+    m) PILOT_HUB_TAG="${OPTARG}";; # Format: "<hub>,<tag>"


do you want to chage m) to p) ?

sebastienvas

minor flag change that will probably require a doc change.

ldemailly · 2017-06-06T01:12:19Z

so the build fails with some linter error ? not sure I'm parsing the error correctly ?

changed flag from m to p

sebastienvas · 2017-06-06T01:42:50Z

Just run bin/fmt.sh

sebastienvas · 2017-06-06T01:43:55Z

install/updateVersion.sh

@@ -43,17 +43,17 @@ source "$VERSION_FILE" || error_exit "Could not source versions"
 while getopts :ci:m:x:C: arg; do


Change
:ci:m:x:C: to :ci:p:x:C:

oh duh me ! thx!

frankbu · 2017-06-06T01:44:28Z

install/updateVersion.sh

@@ -43,7 +43,7 @@ source "$VERSION_FILE" || error_exit "Could not source versions"
 while getopts :ci:m:x:C: arg; do


This "m" needs to be changed to "p" also.

while getopts :ci:p:x:C: arg; do

sebastienvas

PTAL

sebastienvas · 2017-06-06T01:46:41Z

tests/README.md

 ### Options

-* `-m <hub>,<tag>` specify a manager image to use
+* `-m <hub>,<tag>` specify a pilot image to use


Change m to p

* Rbac ingress (#320) * Add ingresses/status to rbac * fix bash'ism (#325) * fix bash'ism we tell people to `curl -L https://git.io/getIstio | sh -` so we can't use bash extentions I was getting [[ unknown command on line 12, fixing this * also updating comment * updateVersion.sh to not modify templates (#229) * istio install templates * fix copy * fix temp var * []byte values * fix linter errors * comment out unused ca vars * gofmt kubernetes.go * fix macros * fix kubeTest.sh * move istio-auth-with-cluster-ca.yaml out of templates dir (#334) * fix broken link (#335) * fixing #321 (#336) fixing broken links * Getting master ready for beta (#322) 0.1.x -> 0.2.x * Add v1/stable version (#351) * Add v1/stable version * Start of a local development directory (#337) * initial skeleton notes for local dev * tweaks * adding the rules.yaml for local dev and updating the scripts * Fixing English typo * Also start to address dev getting started Issue #348 * incorporated most of my noogler notes * Adding the sample quota * adding note about -v=5 for debug/verbose output * Code review comments * typo fix will follow up with moving most of mixer/dev/development.md into this * Moving most of mixer/doc/dev/development.md here (#352) * Moving most of mixer/doc/dev/development.md here https://github.com/istio/mixer/blob/master/doc/dev/development.md to here with updates to make it a bit more generic than just mixer * Also move conventions.md and performance.md here * Review comments And linking the conventions and perf docs * minor update * Manager -> pilot rename (#359) * Manager -> Pilot git ls-files | grep -v tests/e2e|grep -v bookinfo| xargs -n 1 sed -i .bak -e 's/Manager/Pilot/g' As tests/e2e and bookinfo have other Manager unrelated to pilot * manager -> pilot git ls-files | grep -v tests/e2e|grep -v bookinfo| xargs -n 1 sed -i .bak -e 's/manager/pilot/g' * Manual changes in e2e * MANAGER to PILOT git ls-files | xargs -n 1 sed -i .bak -e 's/MANAGER/PILOT/g' and manually excluding some * Rename yaml file too * Last few selective renames Last piece, only remaining ‘manager’ are: ``` ldemailly-macbookpro:istio ldemailly$ git grep -i manager samples/apps/bookinfo/src/reviews/reviews-wlpcfg/servers/LibertyProjectS erver/server.xml: <featureManager> samples/apps/bookinfo/src/reviews/reviews-wlpcfg/servers/LibertyProjectS erver/server.xml: </featureManager> tests/e2e/README.md:### appManager.go tests/e2e/README.md:`appManager` gather apps required for test into a array and deploy them while setup() tests/e2e/framework/BUILD: "appManager.go", tests/e2e/framework/appManager.go:// AppManager organize and deploy apps tests/e2e/framework/appManager.go:type AppManager struct { tests/e2e/framework/appManager.go:// NewAppManager create a new AppManager tests/e2e/framework/appManager.go:func NewAppManager(tmpDir, namespace string, istioctl *Istioctl) *AppManager { tests/e2e/framework/appManager.go: return &AppManager{ tests/e2e/framework/appManager.go:func (am *AppManager) generateAppYaml(a *App) error { tests/e2e/framework/appManager.go:func (am *AppManager) deploy(a *App) error { tests/e2e/framework/appManager.go:func (am *AppManager) Setup() error { tests/e2e/framework/appManager.go:func (am *AppManager) Teardown() error { tests/e2e/framework/appManager.go:func (am *AppManager) AddApp(a *App) { tests/e2e/framework/framework.go: c.Cleanup.RegisterCleanable(c.Kube.AppManager) tests/e2e/framework/kubernetes.go: pilotHub = flag.String("pilot_hub", os.Getenv(pilotHubEnvVar), "Manager hub") tests/e2e/framework/kubernetes.go: pilotTag = flag.String("pilot_tag", os.Getenv(pilotTagEnvVar), "Manager tag") tests/e2e/framework/kubernetes.go: "manager", tests/e2e/framework/kubernetes.go: // App Manager tests/e2e/framework/kubernetes.go: AppManager *AppManager tests/e2e/framework/kubernetes.go: a := NewAppManager(tmpDir, *namespace, i) tests/e2e/framework/kubernetes.go: AppManager: a, tests/e2e/framework/kubernetes.go: case "manager": tests/e2e/tests/bookinfo/demo_test.go: tc.Kube.AppManager.AddApp(demoApp) tests/e2e/tests/mixer/mixer_test.go: tc.Kube.AppManager.AddApp(demoApp) ``` * Review comment changed flag from m to p * make linter happy bin/fmt.sh + review updates * show in logs url being used (#360) A bit more info in logs for when download fails * Update images for Pilot & Unary (#361) * Update image for Unary * Fix forgotten renames * Disabling failing test until #365 is fixed (#366) * Skip TestDenials * Update format and linter to skip git files * Using git ls-files instead of find * Remove extra buildifier call * missed manager->pilot rename and use lowercase -c for ca image (#363) * Make shell utility functions variadic (#377) This simplifies usage a bit by not requiring user to call fmt.Sprintf themselves. * Re-enable TestDenials * Revert "Update images for Pilot & Unary (#361)" This reverts commit 2b210ac. * Revert "Getting master ready for beta (#322)" This reverts commit 910a025. * Update to latest version of manager

* Manager -> Pilot git ls-files | grep -v tests/e2e|grep -v bookinfo| xargs -n 1 sed -i .bak -e 's/Manager/Pilot/g' As tests/e2e and bookinfo have other Manager unrelated to pilot * manager -> pilot git ls-files | grep -v tests/e2e|grep -v bookinfo| xargs -n 1 sed -i .bak -e 's/manager/pilot/g' * Manual changes in e2e * MANAGER to PILOT git ls-files | xargs -n 1 sed -i .bak -e 's/MANAGER/PILOT/g' and manually excluding some * Rename yaml file too * Last few selective renames Last piece, only remaining ‘manager’ are: ``` ldemailly-macbookpro:istio ldemailly$ git grep -i manager samples/apps/bookinfo/src/reviews/reviews-wlpcfg/servers/LibertyProjectS erver/server.xml: <featureManager> samples/apps/bookinfo/src/reviews/reviews-wlpcfg/servers/LibertyProjectS erver/server.xml: </featureManager> tests/e2e/README.md:### appManager.go tests/e2e/README.md:`appManager` gather apps required for test into a array and deploy them while setup() tests/e2e/framework/BUILD: "appManager.go", tests/e2e/framework/appManager.go:// AppManager organize and deploy apps tests/e2e/framework/appManager.go:type AppManager struct { tests/e2e/framework/appManager.go:// NewAppManager create a new AppManager tests/e2e/framework/appManager.go:func NewAppManager(tmpDir, namespace string, istioctl *Istioctl) *AppManager { tests/e2e/framework/appManager.go: return &AppManager{ tests/e2e/framework/appManager.go:func (am *AppManager) generateAppYaml(a *App) error { tests/e2e/framework/appManager.go:func (am *AppManager) deploy(a *App) error { tests/e2e/framework/appManager.go:func (am *AppManager) Setup() error { tests/e2e/framework/appManager.go:func (am *AppManager) Teardown() error { tests/e2e/framework/appManager.go:func (am *AppManager) AddApp(a *App) { tests/e2e/framework/framework.go: c.Cleanup.RegisterCleanable(c.Kube.AppManager) tests/e2e/framework/kubernetes.go: pilotHub = flag.String("pilot_hub", os.Getenv(pilotHubEnvVar), "Manager hub") tests/e2e/framework/kubernetes.go: pilotTag = flag.String("pilot_tag", os.Getenv(pilotTagEnvVar), "Manager tag") tests/e2e/framework/kubernetes.go: "manager", tests/e2e/framework/kubernetes.go: // App Manager tests/e2e/framework/kubernetes.go: AppManager *AppManager tests/e2e/framework/kubernetes.go: a := NewAppManager(tmpDir, *namespace, i) tests/e2e/framework/kubernetes.go: AppManager: a, tests/e2e/framework/kubernetes.go: case "manager": tests/e2e/tests/bookinfo/demo_test.go: tc.Kube.AppManager.AddApp(demoApp) tests/e2e/tests/mixer/mixer_test.go: tc.Kube.AppManager.AddApp(demoApp) ``` * Review comment changed flag from m to p * make linter happy bin/fmt.sh + review updates Former-commit-id: c6bbe3c

* Rbac ingress (#320) * Add ingresses/status to rbac * fix bash'ism (#325) * fix bash'ism we tell people to `curl -L https://git.io/getIstio | sh -` so we can't use bash extentions I was getting [[ unknown command on line 12, fixing this * also updating comment * updateVersion.sh to not modify templates (#229) * istio install templates * fix copy * fix temp var * []byte values * fix linter errors * comment out unused ca vars * gofmt kubernetes.go * fix macros * fix kubeTest.sh * move istio-auth-with-cluster-ca.yaml out of templates dir (#334) * fix broken link (#335) * fixing #321 (#336) fixing broken links * Getting master ready for beta (#322) 0.1.x -> 0.2.x * Add v1/stable version (#351) * Add v1/stable version * Start of a local development directory (#337) * initial skeleton notes for local dev * tweaks * adding the rules.yaml for local dev and updating the scripts * Fixing English typo * Also start to address dev getting started Issue #348 * incorporated most of my noogler notes * Adding the sample quota * adding note about -v=5 for debug/verbose output * Code review comments * typo fix will follow up with moving most of mixer/dev/development.md into this * Moving most of mixer/doc/dev/development.md here (#352) * Moving most of mixer/doc/dev/development.md here https://github.com/istio/mixer/blob/master/doc/dev/development.md to here with updates to make it a bit more generic than just mixer * Also move conventions.md and performance.md here * Review comments And linking the conventions and perf docs * minor update * Manager -> pilot rename (#359) * Manager -> Pilot git ls-files | grep -v tests/e2e|grep -v bookinfo| xargs -n 1 sed -i .bak -e 's/Manager/Pilot/g' As tests/e2e and bookinfo have other Manager unrelated to pilot * manager -> pilot git ls-files | grep -v tests/e2e|grep -v bookinfo| xargs -n 1 sed -i .bak -e 's/manager/pilot/g' * Manual changes in e2e * MANAGER to PILOT git ls-files | xargs -n 1 sed -i .bak -e 's/MANAGER/PILOT/g' and manually excluding some * Rename yaml file too * Last few selective renames Last piece, only remaining ‘manager’ are: ``` ldemailly-macbookpro:istio ldemailly$ git grep -i manager samples/apps/bookinfo/src/reviews/reviews-wlpcfg/servers/LibertyProjectS erver/server.xml: <featureManager> samples/apps/bookinfo/src/reviews/reviews-wlpcfg/servers/LibertyProjectS erver/server.xml: </featureManager> tests/e2e/README.md:### appManager.go tests/e2e/README.md:`appManager` gather apps required for test into a array and deploy them while setup() tests/e2e/framework/BUILD: "appManager.go", tests/e2e/framework/appManager.go:// AppManager organize and deploy apps tests/e2e/framework/appManager.go:type AppManager struct { tests/e2e/framework/appManager.go:// NewAppManager create a new AppManager tests/e2e/framework/appManager.go:func NewAppManager(tmpDir, namespace string, istioctl *Istioctl) *AppManager { tests/e2e/framework/appManager.go: return &AppManager{ tests/e2e/framework/appManager.go:func (am *AppManager) generateAppYaml(a *App) error { tests/e2e/framework/appManager.go:func (am *AppManager) deploy(a *App) error { tests/e2e/framework/appManager.go:func (am *AppManager) Setup() error { tests/e2e/framework/appManager.go:func (am *AppManager) Teardown() error { tests/e2e/framework/appManager.go:func (am *AppManager) AddApp(a *App) { tests/e2e/framework/framework.go: c.Cleanup.RegisterCleanable(c.Kube.AppManager) tests/e2e/framework/kubernetes.go: pilotHub = flag.String("pilot_hub", os.Getenv(pilotHubEnvVar), "Manager hub") tests/e2e/framework/kubernetes.go: pilotTag = flag.String("pilot_tag", os.Getenv(pilotTagEnvVar), "Manager tag") tests/e2e/framework/kubernetes.go: "manager", tests/e2e/framework/kubernetes.go: // App Manager tests/e2e/framework/kubernetes.go: AppManager *AppManager tests/e2e/framework/kubernetes.go: a := NewAppManager(tmpDir, *namespace, i) tests/e2e/framework/kubernetes.go: AppManager: a, tests/e2e/framework/kubernetes.go: case "manager": tests/e2e/tests/bookinfo/demo_test.go: tc.Kube.AppManager.AddApp(demoApp) tests/e2e/tests/mixer/mixer_test.go: tc.Kube.AppManager.AddApp(demoApp) ``` * Review comment changed flag from m to p * make linter happy bin/fmt.sh + review updates * show in logs url being used (#360) A bit more info in logs for when download fails * Update images for Pilot & Unary (#361) * Update image for Unary * Fix forgotten renames * Disabling failing test until #365 is fixed (#366) * Skip TestDenials * Update format and linter to skip git files * Using git ls-files instead of find * Remove extra buildifier call * missed manager->pilot rename and use lowercase -c for ca image (#363) * Make shell utility functions variadic (#377) This simplifies usage a bit by not requiring user to call fmt.Sprintf themselves. * Re-enable TestDenials * Revert "Update images for Pilot & Unary (#361)" This reverts commit 6362d37 [formerly 2b210ac]. * Revert "Getting master ready for beta (#322)" This reverts commit 52e8937 [formerly 910a025]. * Update to latest version of manager Former-commit-id: 6a65da1

* Manager -> Pilot git ls-files | grep -v tests/e2e|grep -v bookinfo| xargs -n 1 sed -i .bak -e 's/Manager/Pilot/g' As tests/e2e and bookinfo have other Manager unrelated to pilot * manager -> pilot git ls-files | grep -v tests/e2e|grep -v bookinfo| xargs -n 1 sed -i .bak -e 's/manager/pilot/g' * Manual changes in e2e * MANAGER to PILOT git ls-files | xargs -n 1 sed -i .bak -e 's/MANAGER/PILOT/g' and manually excluding some * Rename yaml file too * Last few selective renames Last piece, only remaining ‘manager’ are: ``` ldemailly-macbookpro:istio ldemailly$ git grep -i manager samples/apps/bookinfo/src/reviews/reviews-wlpcfg/servers/LibertyProjectS erver/server.xml: <featureManager> samples/apps/bookinfo/src/reviews/reviews-wlpcfg/servers/LibertyProjectS erver/server.xml: </featureManager> tests/e2e/README.md:### appManager.go tests/e2e/README.md:`appManager` gather apps required for test into a array and deploy them while setup() tests/e2e/framework/BUILD: "appManager.go", tests/e2e/framework/appManager.go:// AppManager organize and deploy apps tests/e2e/framework/appManager.go:type AppManager struct { tests/e2e/framework/appManager.go:// NewAppManager create a new AppManager tests/e2e/framework/appManager.go:func NewAppManager(tmpDir, namespace string, istioctl *Istioctl) *AppManager { tests/e2e/framework/appManager.go: return &AppManager{ tests/e2e/framework/appManager.go:func (am *AppManager) generateAppYaml(a *App) error { tests/e2e/framework/appManager.go:func (am *AppManager) deploy(a *App) error { tests/e2e/framework/appManager.go:func (am *AppManager) Setup() error { tests/e2e/framework/appManager.go:func (am *AppManager) Teardown() error { tests/e2e/framework/appManager.go:func (am *AppManager) AddApp(a *App) { tests/e2e/framework/framework.go: c.Cleanup.RegisterCleanable(c.Kube.AppManager) tests/e2e/framework/kubernetes.go: pilotHub = flag.String("pilot_hub", os.Getenv(pilotHubEnvVar), "Manager hub") tests/e2e/framework/kubernetes.go: pilotTag = flag.String("pilot_tag", os.Getenv(pilotTagEnvVar), "Manager tag") tests/e2e/framework/kubernetes.go: "manager", tests/e2e/framework/kubernetes.go: // App Manager tests/e2e/framework/kubernetes.go: AppManager *AppManager tests/e2e/framework/kubernetes.go: a := NewAppManager(tmpDir, *namespace, i) tests/e2e/framework/kubernetes.go: AppManager: a, tests/e2e/framework/kubernetes.go: case "manager": tests/e2e/tests/bookinfo/demo_test.go: tc.Kube.AppManager.AddApp(demoApp) tests/e2e/tests/mixer/mixer_test.go: tc.Kube.AppManager.AddApp(demoApp) ``` * Review comment changed flag from m to p * make linter happy bin/fmt.sh + review updates Former-commit-id: c6bbe3c

Move template and valuetype to mixer/adapter/model/v1beta

Automatic merge from submit-queue. [DO NOT MERGE] Auto PR to update dependencies of mixerclient This PR will be merged automatically once checks are successful. ```release-note none ```

Signed-off-by: Oleksandr Shevchenko <oleksandr.shevchenko@datarobot.com>

…ags (istio#355) * OSSM-8998 Disable istioctl commands with building ldflags (istio#312) * Disable istioctl commands with building ldflags Signed-off-by: bmangoen <9867932+bmangoen@users.noreply.github.com> * Refactoring Signed-off-by: bmangoen <9867932+bmangoen@users.noreply.github.com> * Refactoring and compacting functions Signed-off-by: bmangoen <9867932+bmangoen@users.noreply.github.com> * Remove disabled parameter Signed-off-by: bmangoen <9867932+bmangoen@users.noreply.github.com> --------- Signed-off-by: bmangoen <9867932+bmangoen@users.noreply.github.com> Co-authored-by: bmangoen <9867932+bmangoen@users.noreply.github.com> * Add copyright banner (istio#359) Signed-off-by: bmangoen <9867932+bmangoen@users.noreply.github.com> Co-authored-by: bmangoen <9867932+bmangoen@users.noreply.github.com> * Remove leftover unsupportedCmd Signed-off-by: bmangoen <9867932+bmangoen@users.noreply.github.com> --------- Signed-off-by: bmangoen <9867932+bmangoen@users.noreply.github.com> Co-authored-by: bmangoen <9867932+bmangoen@users.noreply.github.com>

Signed-off-by: bmangoen <9867932+bmangoen@users.noreply.github.com> Co-authored-by: bmangoen <9867932+bmangoen@users.noreply.github.com>

ldemailly added 2 commits June 5, 2017 16:41

Manager -> Pilot

9aec415

git ls-files | grep -v tests/e2e|grep -v bookinfo| xargs -n 1 sed -i .bak -e 's/Manager/Pilot/g' As tests/e2e and bookinfo have other Manager unrelated to pilot

manager -> pilot

ad1d89c

git ls-files | grep -v tests/e2e|grep -v bookinfo| xargs -n 1 sed -i .bak -e 's/manager/pilot/g'

googlebot added the cla: yes label Jun 5, 2017

ldemailly requested review from andraxylia, kyessenov and sebastienvas June 5, 2017 23:44

ldemailly changed the title ~~Manager pilot rename~~ Manager -> pilot rename Jun 5, 2017

kyessenov reviewed Jun 5, 2017

View reviewed changes

ldemailly added 4 commits June 5, 2017 16:57

Manual changes in e2e

6012da4

MANAGER to PILOT

f009f52

git ls-files | xargs -n 1 sed -i .bak -e 's/MANAGER/PILOT/g' and manually excluding some

Rename yaml file too

df20d72

kyessenov approved these changes Jun 6, 2017

View reviewed changes

sebastienvas reviewed Jun 6, 2017

View reviewed changes

Review comment

0d6d7f9

changed flag from m to p

sebastienvas reviewed Jun 6, 2017

View reviewed changes

frankbu reviewed Jun 6, 2017

View reviewed changes

sebastienvas reviewed Jun 6, 2017

View reviewed changes

make linter happy bin/fmt.sh + review updates

c546ae8

sebastienvas approved these changes Jun 6, 2017

View reviewed changes

sebastienvas merged commit c6bbe3c into master Jun 6, 2017

zenlint pushed a commit to zenlint/istio that referenced this pull request Aug 30, 2017

The diagram mentioned is below the text, not above (istio#359)

ecdd985

guptasu added a commit to guptasu/istio that referenced this pull request Jun 11, 2018

introduce api/mixer/adapter/model/v1beta (istio#359)

12edb32

Move template and valuetype to mixer/adapter/model/v1beta

howardjohn pushed a commit to howardjohn/istio that referenced this pull request Jan 12, 2020

watch all namespaces. (istio#359)

7b4f3f7

luksa pushed a commit to luksa/istio that referenced this pull request Jun 30, 2021

MAISTRA-2251: Update SME status upon failures (istio#359)

e69bfeb

luksa pushed a commit to luksa/istio that referenced this pull request Feb 22, 2022

[mec] MAISTRA-2251: Update SME status upon failures (istio#359)

6d6134a

luksa pushed a commit to luksa/istio that referenced this pull request Apr 29, 2022

[mec] MAISTRA-2251: Update SME status upon failures (istio#359)

35e4145

antonioberben pushed a commit to antonioberben/istio that referenced this pull request Jan 29, 2024

[jaeger] Disable Jaeger allInOne ingress (istio#359)

8aee713

Signed-off-by: Oleksandr Shevchenko <oleksandr.shevchenko@datarobot.com>

dgn pushed a commit to dgn/istio that referenced this pull request Jun 24, 2025

Add copyright banner (istio#359)

346b196

Signed-off-by: bmangoen <9867932+bmangoen@users.noreply.github.com> Co-authored-by: bmangoen <9867932+bmangoen@users.noreply.github.com>

fjglira pushed a commit to fjglira/istio that referenced this pull request Sep 26, 2025

Add copyright banner (istio#359)

c448aa2

Signed-off-by: bmangoen <9867932+bmangoen@users.noreply.github.com> Co-authored-by: bmangoen <9867932+bmangoen@users.noreply.github.com>

cam-garrison pushed a commit to cam-garrison/istio that referenced this pull request Oct 29, 2025

Add copyright banner (istio#359)

a691ca7

Signed-off-by: bmangoen <9867932+bmangoen@users.noreply.github.com> Co-authored-by: bmangoen <9867932+bmangoen@users.noreply.github.com>

cam-garrison pushed a commit to cam-garrison/istio that referenced this pull request Jan 20, 2026

Add copyright banner (istio#359)

5c36eba

Signed-off-by: bmangoen <9867932+bmangoen@users.noreply.github.com> Co-authored-by: bmangoen <9867932+bmangoen@users.noreply.github.com>

dgn pushed a commit to dgn/istio that referenced this pull request Feb 17, 2026

Add copyright banner (istio#359)

73a6ba2

Signed-off-by: bmangoen <9867932+bmangoen@users.noreply.github.com> Co-authored-by: bmangoen <9867932+bmangoen@users.noreply.github.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Manager -> pilot rename#359

Manager -> pilot rename#359
sebastienvas merged 8 commits intomasterfrom
manager-pilot-rename

ldemailly commented Jun 5, 2017 •

edited

Loading

Uh oh!

kyessenov Jun 5, 2017

Uh oh!

ldemailly Jun 6, 2017

Uh oh!

kyessenov left a comment

Uh oh!

sebastienvas Jun 6, 2017

Uh oh!

sebastienvas left a comment

Uh oh!

ldemailly commented Jun 6, 2017

Uh oh!

sebastienvas commented Jun 6, 2017

Uh oh!

sebastienvas Jun 6, 2017 •

edited

Loading

Uh oh!

ldemailly Jun 6, 2017

Uh oh!

frankbu Jun 6, 2017

Uh oh!

sebastienvas left a comment

Uh oh!

sebastienvas Jun 6, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

		@@ -1,4 +1,4 @@
		# Manager service for discovery
		# Pilot service for discovery

		@@ -43,17 +43,17 @@ source "$VERSION_FILE" \|\| error_exit "Could not source versions"
		while getopts :ci:m:x:C: arg; do

		@@ -43,7 +43,7 @@ source "$VERSION_FILE" \|\| error_exit "Could not source versions"
		while getopts :ci:m:x:C: arg; do

Conversation

ldemailly commented Jun 5, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kyessenov Jun 5, 2017

Choose a reason for hiding this comment

Uh oh!

ldemailly Jun 6, 2017

Choose a reason for hiding this comment

Uh oh!

kyessenov left a comment

Choose a reason for hiding this comment

Uh oh!

sebastienvas Jun 6, 2017

Choose a reason for hiding this comment

Uh oh!

sebastienvas left a comment

Choose a reason for hiding this comment

Uh oh!

ldemailly commented Jun 6, 2017

Uh oh!

sebastienvas commented Jun 6, 2017

Uh oh!

sebastienvas Jun 6, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ldemailly Jun 6, 2017

Choose a reason for hiding this comment

Uh oh!

frankbu Jun 6, 2017

Choose a reason for hiding this comment

Uh oh!

sebastienvas left a comment

Choose a reason for hiding this comment

Uh oh!

sebastienvas Jun 6, 2017

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

ldemailly commented Jun 5, 2017 •

edited

Loading

sebastienvas Jun 6, 2017 •

edited

Loading