Skip to content

vendor_update_Feb17_2018#3588

Merged
ldemailly merged 3 commits intomasterfrom
fortio_update
Feb 18, 2018
Merged

vendor_update_Feb17_2018#3588
ldemailly merged 3 commits intomasterfrom
fortio_update

Conversation

@ldemailly
Copy link
Copy Markdown
Member

@ldemailly ldemailly commented Feb 17, 2018

Ran dep ensure —update

Also bump up fortio version

Fixes #3585

@ldemailly
vendor_update_Feb17_2018
e687468 
Ran dep ensure —update

Also bump up fortio version

Fixes #3585
@ldemailly ldemailly requested a review from a team February 17, 2018 19:18
@istio-merge-robot
Copy link
Copy Markdown

istio-merge-robot commented Feb 17, 2018

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
We suggest the following additional approver: costinm

Assign the PR to them by writing /assign @costinm in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@ldemailly ldemailly mentioned this pull request Feb 17, 2018
Merged
@ldemailly
Copy link
Copy Markdown
Member Author

ldemailly commented Feb 17, 2018

/test e2e-suite-rbac-auth

1 similar comment
@ldemailly
Copy link
Copy Markdown
Member Author

ldemailly commented Feb 17, 2018

/test e2e-suite-rbac-auth

@ldemailly
Update to head
b4ef682 
istio/old_vendor-istio_repo#2 is merged

Ran dep ensure
A bit surprised the api SHA change didn’t trigger any file change
istio/api#376 (comment)
@ldemailly ldemailly merged commit 951f137 into master Feb 18, 2018
@ldemailly ldemailly deleted the fortio_update branch February 18, 2018 02:49
@istio-testing
Copy link
Copy Markdown
Collaborator

istio-testing commented Feb 18, 2018

@ldemailly: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
prow/istio-pilot-e2e.sh b4ef682 link /test istio-pilot-e2e
Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@adityaanand11 adityaanand11 mentioned this pull request Nov 18, 2021
Closed
PetrMc pushed a commit to PetrMc/istio-petrmc-upstream-fork that referenced this pull request Jan 14, 2026
@soloio-bot
Merge pull request istio#3588 from solo-io/merge-conflict-master
94a009a 
[master-solo] Fix merge conflicts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@mandarjog mandarjog mandarjog approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ldemailly @istio-merge-robot @istio-testing @mandarjog @googlebot