Skip to content

Add CA option to use upstream CA for provisioning cert.#3526

Merged
myidpt merged 1 commit intoistio:masterfrom
myidpt:mc
Feb 15, 2018
Merged

Add CA option to use upstream CA for provisioning cert.#3526
myidpt merged 1 commit intoistio:masterfrom
myidpt:mc

Conversation

@myidpt
Copy link
Copy Markdown

@myidpt myidpt commented Feb 15, 2018

This is part of the multi-cluster CA configuration, and it could also support the plug-in CAs.

@myidpt myidpt requested review from a team, lei-tang and wattli February 15, 2018 19:02
@myidpt myidpt changed the title Add CA option to use ustream CA for provisioning cert. Add CA option to use upstream CA for provisioning cert. Feb 15, 2018
Copy link
Copy Markdown
Contributor

@wattli wattli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

if opts.selfSignedCA {
if opts.upstreamCAAddress != "" {
log.Info("Rely on upstream CA to provision CA certificate")
caOpts, err = ca.NewIntegratedIstioCAOptions(opts.upstreamCAAddress, opts.upstreamCACertFile, opts.upstreamAuth,
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider breaking line, this looks long.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure. I will to this in the next PR.

@istio-merge-robot
Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wattli

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@istio-testing
Copy link
Copy Markdown
Collaborator

istio-testing commented Feb 15, 2018

@myidpt: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
prow/e2e-smoke.sh 476ba78 link /test e2e-smoke
Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@myidpt myidpt merged commit 8f52b2f into istio:master Feb 15, 2018
@myidpt myidpt deleted the mc branch February 24, 2018 00:13
PetrMc pushed a commit to PetrMc/istio-petrmc-upstream-fork that referenced this pull request Jan 14, 2026
Include the subzone when computing the locality of Workloads.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants