Restoring TESTOPTS which was accidentally removed#3516
Restoring TESTOPTS which was accidentally removed#3516istio-merge-robot merged 3 commits intoistio:masterfrom
Conversation
|
@ldemailly note that the tests won't pass until #3517 lands |
|
/retest |
|
/test istio-pilot-e2e |
|
/retest |
|
@ldemailly not sure what's going on with the tests ... is the prow environment experiencing issues ATM? |
|
The prior 13 runs of istio-pilot-e2e completed successfully. |
|
The only thing I noticed was a unspecified -n parameter: Run "kubectl delete --kubeconfig /home/bootstrap/.kube/config -n -f -" on input: possibly from either of tests/e2e/tests/pilot/util/infra.go: return util.RunInput(fmt.Sprintf("kubectl delete --kubeconfig %s -n %s -f -",
One of the callers says // automatic injection webhook is not namespaced. So I'm not sure if -n shouldn't be specified if there's not a namespace (or if the %s should be quoted so at least the empty string is passed [which seems to match the default]), but in any case I'm probably chasing after a symptom rather than a problem. |
|
@mattdelco good find, but I don't think that's anything new. Probably worth raising an issue, however. I'm able to run successfully on GKE with the following parameters: This matches prow's command-line from the failing test. It's a mystery why prow isn't working. |
|
/test istio-pilot-e2e |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ldemailly The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
|
/test all [submit-queue is verifying that this PR is safe to merge] |
|
Automatic merge from submit-queue. |
|
@nmittler: The following test failed, say
DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Removed by abcd9d4