Skip to content

Restoring TESTOPTS which was accidentally removed#3516

Merged
istio-merge-robot merged 3 commits intoistio:masterfrom
nmittler:testopts
Feb 17, 2018
Merged

Restoring TESTOPTS which was accidentally removed#3516
istio-merge-robot merged 3 commits intoistio:masterfrom
nmittler:testopts

Conversation

@nmittler
Copy link
Copy Markdown
Contributor

Removed by abcd9d4

@nmittler
Copy link
Copy Markdown
Contributor Author

@ldemailly note that the tests won't pass until #3517 lands

@nmittler
Copy link
Copy Markdown
Contributor Author

/retest

@nmittler
Copy link
Copy Markdown
Contributor Author

/test istio-pilot-e2e

@nmittler
Copy link
Copy Markdown
Contributor Author

/retest

@nmittler
Copy link
Copy Markdown
Contributor Author

@ldemailly not sure what's going on with the tests ... is the prow environment experiencing issues ATM?

@mattdelco
Copy link
Copy Markdown
Contributor

The prior 13 runs of istio-pilot-e2e completed successfully.

@mattdelco
Copy link
Copy Markdown
Contributor

The only thing I noticed was a unspecified -n parameter:

Run "kubectl delete --kubeconfig /home/bootstrap/.kube/config -n  -f -" on input:

possibly from either of

tests/e2e/tests/pilot/util/infra.go:	return util.RunInput(fmt.Sprintf("kubectl delete --kubeconfig %s -n %s -f -",
tests/util/kubeUtils.go: _, err := Shell("kubectl delete -n %s -f %s", namespace, yamlFileName)

One of the callers says

// automatic injection webhook is not namespaced.

So I'm not sure if -n shouldn't be specified if there's not a namespace (or if the %s should be quoted so at least the empty string is passed [which seems to match the default]), but in any case I'm probably chasing after a symptom rather than a problem.

@nmittler
Copy link
Copy Markdown
Contributor Author

@mattdelco good find, but I don't think that's anything new. Probably worth raising an issue, however.

I'm able to run successfully on GKE with the following parameters:

-tag f2c06884184c2e496398760868402b5778420f25 -logtostderr -mixer=true -use-sidecar-injector=true -use-admission-webhook=false

This matches prow's command-line from the failing test. It's a mystery why prow isn't working.

@nmittler
Copy link
Copy Markdown
Contributor Author

/test istio-pilot-e2e

@ldemailly
Copy link
Copy Markdown
Member

ldemailly commented Feb 17, 2018

/lgtm
(looks like you found what was wrong as it looks green - thanks a lot @mattdelco for the watchful eyes!)

@istio-merge-robot
Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ldemailly

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@istio-merge-robot
Copy link
Copy Markdown

/test all [submit-queue is verifying that this PR is safe to merge]

@istio-merge-robot
Copy link
Copy Markdown

Automatic merge from submit-queue.

@istio-merge-robot istio-merge-robot merged commit 3795f0f into istio:master Feb 17, 2018
@istio-testing
Copy link
Copy Markdown
Collaborator

@nmittler: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
prow/istio-pilot-e2e.sh 8c48169 link /test istio-pilot-e2e
Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants