Correctly supporting auth modes in pilot e2e tests#3517
Merged
istio-merge-robot merged 1 commit intoistio:masterfrom Feb 15, 2018
Merged
Correctly supporting auth modes in pilot e2e tests#3517istio-merge-robot merged 1 commit intoistio:masterfrom
istio-merge-robot merged 1 commit intoistio:masterfrom
Conversation
Introduced by abcd9d4
Contributor
Author
|
@ldemailly this will certainly add logging in cases where authmode is configured as |
Contributor
Author
|
/test istio-pilot-e2e |
Member
|
filled #3518 for the prow error /test istio-pilot-e2e |
ldemailly
approved these changes
Feb 15, 2018
Member
|
/lgtm I'm a bit worried about not running the prow test though |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ldemailly The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
Member
Contributor
Author
|
/test istio-pilot-e2e |
1 similar comment
Contributor
Author
|
/test istio-pilot-e2e |
|
/test all [submit-queue is verifying that this PR is safe to merge] |
|
Automatic merge from submit-queue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduced by abcd9d4