Merged
Conversation
Member
|
/lgtm |
ldemailly
approved these changes
Feb 14, 2018
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ldemailly The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
Member
|
merged as it passed build and lint and is needed to get failure logs in other PRs |
Member
|
initial fix for #3499 |
nmittler
added a commit
to nmittler/istio
that referenced
this pull request
Feb 23, 2018
This was removed by istio#3502 To cleanly do this, I've separated out the configuration from the test runtime environment. I've renamed `Infra` to `Environment` to make this clear. Because fields are now split across `Config` and `Environment, I've also create a new `TemplateData` struct that merges all the common template parameters into a single struct. This way the template files do not have to change. The separation of template params from the environment should also help a bit with maintenance going forward.
istio-merge-robot
pushed a commit
that referenced
this pull request
Feb 23, 2018
Automatic merge from submit-queue. Restore logging of test configuration for pilot e2e tests This was removed by #3502 To cleanly do this, I've separated out the configuration from the test runtime environment. I've renamed `Infra` to `Environment` to make this clear. Because fields are now split across `Config` and `Environment`, I've also create a new `TemplateData` struct that merges all the common template parameters into a single struct. This way the template files do not have to change. The separation of template params from the environment should also help a bit with maintenance going forward.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.