Update .gitignore and make clean. Fix namespace in install template.#3492
Update .gitignore and make clean. Fix namespace in install template.#3492istio-merge-robot merged 1 commit intoistio:masterfrom
Conversation
|
Hi @jeffmendoza. Thanks for your PR. I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
| # Install generated files | ||
| install/consul/istio.yaml | ||
| install/eureka/istio.yaml | ||
| install/kubernetes/addons/grafana.yaml |
There was a problem hiding this comment.
The right fix would be to not generate the files under the source tree, but under $OUT.
Can you make sure the files are deleted from git as well ? And I assume istio.VERSION may need to be ignored too ?
There was a problem hiding this comment.
BTW - it's ok to leave the 'out of the source tree' for separate PR, but check if the files are not checked in,
I think 2 are and 2 are not.
There was a problem hiding this comment.
These files are not checked in, recently removed. Some updates had been committed to the generated files, then moved over to the template, causing some bugs.
Created #3496
istio.VERSION is currently checked in, but just gets updated. I'm not sure what the desired behavior is though.
|
/lgtm |
|
/ok-to-test |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ldemailly The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
|
/test all [submit-queue is verifying that this PR is safe to merge] |
|
Automatic merge from submit-queue. |
[solo-io/istio merge job] Nightly merge of upstream into master-solo
No description provided.