[WIP] Mixer: Make runtime2 default#3448
Merged
istio-merge-robot merged 1 commit intoistio:masterfrom Feb 22, 2018
ozevren:runtime2
Merged
[WIP] Mixer: Make runtime2 default#3448istio-merge-robot merged 1 commit intoistio:masterfrom ozevren:runtime2
istio-merge-robot merged 1 commit intoistio:masterfrom
ozevren:runtime2
Conversation
Contributor
Author
|
/retest |
Contributor
|
So much green! /lgtm |
geeknoid
approved these changes
Feb 13, 2018
Member
|
/hold can you measure with on and off using we also need to check memory footprint in light of recent reports |
Contributor
|
I think this should go ahead now. /lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: geeknoid, mandarjog The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
Contributor
@ldemailly we should switch to runtime2. |
|
/test all [submit-queue is verifying that this PR is safe to merge] |
Contributor
Author
|
I have one more fix to push before flipping this bit. I'll do that
tomorrow. Until then, please do not remove /hold on this.
…On Wed, Feb 21, 2018 at 5:24 PM Istio Auto Merge Robot < ***@***.***> wrote:
/test all [submit-queue is verifying that this PR is safe to merge]
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#3448 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AQR8I3eAo0tbCSRp67qtFDPclgFvjAGlks5tXMG3gaJpZM4SEPT7>
.
|
|
Automatic merge from submit-queue. |
PetrMc
pushed a commit
to PetrMc/istio-petrmc-upstream-fork
that referenced
this pull request
Jan 14, 2026
* initial draft of namespace service-scope support Signed-off-by: Lucas Copi <lucas.copi@solo.io> * add namespace watch Signed-off-by: Lucas Copi <lucas.copi@solo.io> * sfix test null pointers, general cleanup * add new integration test Signed-off-by: Lucas Copi <lucas.copi@solo.io> * add unit test, review updates Signed-off-by: Lucas Copi <lucas.copi@solo.io> * adjust integration tests Signed-off-by: Lucas Copi <lucas.copi@solo.io> * Update releasenotes/solo/3276.yaml Co-authored-by: Steven Landow <steven.landow@solo.io> * refactor integration tests to be more efficient Signed-off-by: Lucas Copi <lucas.copi@solo.io> * fix variable reinstantiation bug Signed-off-by: Lucas Copi <lucas.copi@solo.io> --------- Signed-off-by: Lucas Copi <lucas.copi@solo.io> Co-authored-by: Steven Landow <steven.landow@solo.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Work in progress, not ready for review/checkin