Make IsNetworkFilterConfig exported#3252
Merged
istio-merge-robot merged 2 commits intoistio:masterfrom Feb 16, 2018
Merged
Conversation
Before this change, it is hard to import the v1 API structures and define a new custom NetworkFilterConfig in an external module. A NetworkFilterConfig needs to implement isNetworkFilterConfig, but that method is private to the v1 module. This change makes it exported. This is useful for people who want to write Pilot webhooks that mutate the xDS data---the relevant data structures are already defined. Signed-off-by: Spike Curtis <spike@tigera.io>
rshriram
approved these changes
Feb 7, 2018
Contributor
|
Due to the poor linter subtyping inference, you need to add a comment on every |
Signed-off-by: Spike Curtis <spike@tigera.io>
Member
Author
|
@kyessenov fixed! |
Contributor
|
/lgtm
…On Thu, Feb 15, 2018 at 2:30 PM Spike Curtis ***@***.***> wrote:
@kyessenov <https://github.com/kyessenov> fixed!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#3252 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AJGIxuBE698MndeT7aoQl1lDKt_hghu0ks5tVLAbgaJpZM4R7_Dd>
.
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kyessenov The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
|
/test all [submit-queue is verifying that this PR is safe to merge] |
|
Automatic merge from submit-queue. |
PetrMc
pushed a commit
to PetrMc/istio-petrmc-upstream-fork
that referenced
this pull request
Jan 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this change, it is hard to import the v1 API structures and define
a new custom NetworkFilterConfig in an external module. A NetworkFilterConfig
needs to implement isNetworkFilterConfig, but that method is private to the v1
module. This change makes it exported.
This is useful for people who want to write Pilot webhooks that mutate
the xDS data---the relevant data structures are already defined.
Signed-off-by: Spike Curtis spike@tigera.io