Skip to content

Edits to YAMLs#30

Closed
kyessenov wants to merge 2 commits intoistio:masterfrom
kyessenov:suggestions
Closed

Edits to YAMLs#30
kyessenov wants to merge 2 commits intoistio:masterfrom
kyessenov:suggestions

Conversation

@kyessenov
Copy link
Copy Markdown
Contributor

@kyessenov kyessenov commented Mar 9, 2017

Some minor edits. Feel free to close and apply in your PR.


This change is Reviewable

@kyessenov kyessenov requested a review from frankbu March 9, 2017 00:26
args:
- proxy
- sidecar
- -n
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there an API for proxy to obtain the namespace in which it is running or can we pass the namespace via env vars?

Copy link
Copy Markdown
Contributor

@andraxylia andraxylia Mar 9, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is proxy in this yaml is deployed in a different namespace? Please remove this.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This restricts traffic to a namespace and helps to reduce load on the controller and the restart frequency. We can add another flag to use the current namespace, which I like.

Copy link
Copy Markdown
Contributor

@frankbu frankbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@frankbu
Copy link
Copy Markdown
Contributor

frankbu commented Mar 9, 2017

Closing this one. I'll incorporate these changes in another PR, where I will also updates the demo to work with the fault-rule design change, i.e., set the fault (delay) in a route-rule instead of destination-policy.

@frankbu frankbu closed this Mar 9, 2017
mandarjog pushed a commit that referenced this pull request Oct 31, 2017
* Initial example deployment

* Add start-up command to manager

* Complete echoheaders example

* Minor fix
kyessenov pushed a commit to kyessenov/istio that referenced this pull request Aug 13, 2018
* Parse response status code.

* Add unit_test
rajusharma pushed a commit to rajusharma/istio that referenced this pull request Jul 2, 2019
howardjohn pushed a commit to howardjohn/istio that referenced this pull request Jan 12, 2020
* Initial implementation of IstioFeature

* Move names out to name package

* Cleanup

* Cleanup

* Minor cleanup

* Lint

* Lint
deva26 pushed a commit to deva26/istio that referenced this pull request Jun 24, 2020
Add helm support for (only)service entry crd installation
istio-testing pushed a commit that referenced this pull request Aug 11, 2020
* [release-1.5] fix authz suffix matching in TCP (#30)

* Update base image (#26284) (#33)

Co-authored-by: Eric Van Norman <ericvn@us.ibm.com>

Co-authored-by: Yangmin Zhu <ymzhu@google.com>
Co-authored-by: Eric Van Norman <ericvn@us.ibm.com>
antonioberben pushed a commit to antonioberben/istio that referenced this pull request Jan 29, 2024
Added extraSecretMounts option for TLS support
@pavan359t pavan359t mentioned this pull request Sep 6, 2024
2 tasks
luksa pushed a commit to luksa/istio that referenced this pull request Oct 14, 2024
* OSSM-6600 Avoid failures to be hidden on integration test

Avoid to use eval when integration test are executed

Fix ocp test execution

* Fix junit report execution on integration test

Fix error in command execution for ocp test run with junit report

test fix junit report generator for integration test

* Adding debugging to the integration script

* More debugging for OCP execution

* Avoid hidde exit status on ocp test execution
johnlanni pushed a commit to johnlanni/istio that referenced this pull request Jun 17, 2025
* add mcp-server.so

* add space

* add arm version
dgn pushed a commit to dgn/istio that referenced this pull request Jun 24, 2025
* OSSM-6600 Avoid failures to be hidden on integration test

Avoid to use eval when integration test are executed

Fix ocp test execution

* Fix junit report execution on integration test

Fix error in command execution for ocp test run with junit report

test fix junit report generator for integration test

* Adding debugging to the integration script

* More debugging for OCP execution

* Avoid hidde exit status on ocp test execution
cam-garrison pushed a commit to cam-garrison/istio that referenced this pull request Oct 29, 2025
* OSSM-6600 Avoid failures to be hidden on integration test

Avoid to use eval when integration test are executed

Fix ocp test execution

* Fix junit report execution on integration test

Fix error in command execution for ocp test run with junit report

test fix junit report generator for integration test

* Adding debugging to the integration script

* More debugging for OCP execution

* Avoid hidde exit status on ocp test execution
cam-garrison pushed a commit to cam-garrison/istio that referenced this pull request Jan 20, 2026
* OSSM-6600 Avoid failures to be hidden on integration test

Avoid to use eval when integration test are executed

Fix ocp test execution

* Fix junit report execution on integration test

Fix error in command execution for ocp test run with junit report

test fix junit report generator for integration test

* Adding debugging to the integration script

* More debugging for OCP execution

* Avoid hidde exit status on ocp test execution
dgn pushed a commit to dgn/istio that referenced this pull request Feb 17, 2026
* OSSM-6600 Avoid failures to be hidden on integration test

Avoid to use eval when integration test are executed

Fix ocp test execution

* Fix junit report execution on integration test

Fix error in command execution for ocp test run with junit report

test fix junit report generator for integration test

* Adding debugging to the integration script

* More debugging for OCP execution

* Avoid hidde exit status on ocp test execution
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants