Merged
Conversation
Member
Author
|
Adding a cherrypick to 1.5, 1.6, and 1.4 here. Note that the images will have to be published and the hub will have to be updated for them before those can merge. |
Contributor
|
LGTM - Waiting on a Node.js update. |
Member
Author
|
/retest |
ericvn
approved these changes
Jun 3, 2020
Member
Author
|
/test integ-distroless-k8s-tests_istio |
Collaborator
|
In response to a cherrypick label: #24304 failed to apply on top of branch "release-1.4": |
Collaborator
|
In response to a cherrypick label: new issue created for failed cherrypick: #24391 |
Collaborator
|
In response to a cherrypick label: #24304 failed to apply on top of branch "release-1.5": |
Collaborator
|
In response to a cherrypick label: new issue created for failed cherrypick: #24392 |
Collaborator
|
In response to a cherrypick label: #24304 failed to apply on top of branch "release-1.6": |
Collaborator
|
In response to a cherrypick label: new issue created for failed cherrypick: #24393 |
nschhina
pushed a commit
to nschhina/istio
that referenced
this pull request
Jun 18, 2020
* Update jquery and nodejs * Update docker hub. * Removed hardcoded version * Updated to node 12.18
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates the nodejs and jquery versions used in bookinfo. This is the master version of #24289
1.4, 1.5, and 1.6 are all based on bookinfo 1.15.0. Master advances to 1.16.0.
Testing done:
Manually tested that all three star versions show up when viewing the website
make test passes
No errors in the browser console.
Note that many tests expect the bookinfo images to already exist and the images do not get built in the pull request process. These tests will fail until the images exist.
This fixes:
NodeJS
jQuery