feat(injector): add initial support for canonical service revision#20943
Merged
istio-testing merged 2 commits intoistio:masterfrom Feb 7, 2020
Merged
Conversation
…beling Signed-off-by: Douglas Reid <douglas-reid@users.noreply.github.com>
howardjohn
approved these changes
Feb 7, 2020
Member
|
I put a hold if you want someone with more knowledge to review |
mandarjog
approved these changes
Feb 7, 2020
Contributor
mandarjog
left a comment
There was a problem hiding this comment.
We are not yet emitting this label from the stats plugin, we only have the service name.
douglas-reid
added a commit
to douglas-reid/istio
that referenced
this pull request
Feb 7, 2020
sdake
pushed a commit
to sdake/istio
that referenced
this pull request
Feb 21, 2020
…stio#20943) * feat(injector): add initial support for canonical service revision labeling Signed-off-by: Douglas Reid <douglas-reid@users.noreply.github.com> * update bootstrap to match ICS proposal for v2 support
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is the second in a series meant to support the approved Istio Canonical Service proposal.
In particular, it adds the
service.istio.io/canonical-revisionlabel according to the heuristic defined in the proposal (absent user-defined label support).It also adds support for extraction of these labels to the bootstrap for v2 telemetry support.
[ ] Configuration Infrastructure
[ ] Docs
[ ] Installation
[ ] Networking
[ ] Performance and Scalability
[ X ] Policies and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure