Templating the cni validation container name#20923
Merged
istio-testing merged 5 commits intoistio:masterfrom Feb 8, 2020
Merged
Templating the cni validation container name#20923istio-testing merged 5 commits intoistio:masterfrom
istio-testing merged 5 commits intoistio:masterfrom
Conversation
howardjohn
approved these changes
Feb 7, 2020
Member
howardjohn
left a comment
There was a problem hiding this comment.
probably need to modify the proto and/or default.yaml? if not remove the hold
Collaborator
|
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
Collaborator
|
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
Contributor
Author
|
/retest |
Contributor
Author
|
/test integ-security-k8s-tests_istio |
Collaborator
|
In response to a cherrypick label: #20923 failed to apply on top of branch "release-1.5": |
stewartbutler
added a commit
to stewartbutler/istio
that referenced
this pull request
Feb 8, 2020
* Templating the cni validation container name * Adding changed proto with new field * gencheck * Updating golden yaml * More gencheck (cherry picked from commit ddf3c69)
stewartbutler
added a commit
to stewartbutler/installer
that referenced
this pull request
Feb 13, 2020
stewartbutler
added a commit
to stewartbutler/operator
that referenced
this pull request
Feb 13, 2020
istio-testing
pushed a commit
to istio/installer
that referenced
this pull request
Feb 13, 2020
istio-testing
pushed a commit
to istio/operator
that referenced
this pull request
Feb 13, 2020
* Manual cherrypick of (istio/istio#20923) * Updated installer SHA and ran make gen
istio-testing
pushed a commit
that referenced
this pull request
Feb 13, 2020
* Templating the cni validation container name (#20923) * Templating the cni validation container name * Adding changed proto with new field * gencheck * Updating golden yaml * More gencheck (cherry picked from commit ddf3c69) * Regenerating assets after cherrypick * Pulling from upstream and regenerating assets
sdake
pushed a commit
to sdake/istio
that referenced
this pull request
Feb 21, 2020
* Templating the cni validation container name * Adding changed proto with new field * gencheck * Updating golden yaml * More gencheck
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.