Make istiod.enabled always true#20883
Merged
istio-testing merged 2 commits intoistio:masterfrom Feb 6, 2020
Merged
Conversation
elfinhe
approved these changes
Feb 5, 2020
Member
elfinhe
left a comment
There was a problem hiding this comment.
now i do see why helm template is hard to maintain...
Member
Author
Just keep deleting stuff, it gets easier 🙂 |
sdake
pushed a commit
to sdake/istio
that referenced
this pull request
Feb 21, 2020
* Make istiod.enabled always true * Gen
beckend
reviewed
Feb 23, 2020
| fsGroup: 1337 | ||
| volumes: | ||
| {{- if or .Values.global.controlPlaneSecurityEnabled (and .Values.global.configValidation (not .Values.global.istiod.enabled)) }} | ||
| - name: istio-certs |
There was a problem hiding this comment.
removing this is causing an error deploying galley manifest
Member
Author
There was a problem hiding this comment.
can you open an issue with more details? it's very likely we will remove galley entirely by the time we ship 1.6 though, and this commit is not included in 1.5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is for master only, not 1.5 backport